From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Andy Lutomirski <luto@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>, Andi Kleen <ak@linux.intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>, Jiri Olsa <jolsa@redhat.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
daniel@iogearbox.net
Subject: Re: [PATCH V4 1/3] kallsyms: Simplify update_iter_mod()
Date: Wed, 6 Jun 2018 15:59:14 -0300 [thread overview]
Message-ID: <20180606185914.GJ24381@kernel.org> (raw)
In-Reply-To: <20180606143727.03da2e26@vmware.local.home>
Em Wed, Jun 06, 2018 at 02:37:27PM -0400, Steven Rostedt escreveu:
> On Wed, 6 Jun 2018 15:13:02 +0200
> Peter Zijlstra <peterz@infradead.org> wrote:
>
> > On Wed, Jun 06, 2018 at 03:54:09PM +0300, Adrian Hunter wrote:
> > > The logic in update_iter_mod() is overcomplicated and gets worse every time
> > > another get_ksymbol_* function is added.
> > >
> > > In preparation for adding another get_ksymbol_* function, simplify logic in
> > > update_iter_mod().
> > >
> > > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> > > Acked-by: Andi Kleen <ak@linux.intel.com>
> >
> > Both Daniel and Steven touched this function last year, let's also Cc
> > them.
>
> Thanks for Ccing me. I tested the patch to make sure my changes still
> work and they do:
>
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Since you said you tested the patch, may I replace the Acked-by with the
stronger Tested-by?
Thanks,
- Arnaldo
next prev parent reply other threads:[~2018-06-06 18:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 12:54 [PATCH V4 0/3] perf tools and x86 PTI entry trampolines Adrian Hunter
2018-06-06 12:54 ` [PATCH V4 1/3] kallsyms: Simplify update_iter_mod() Adrian Hunter
2018-06-06 13:13 ` Peter Zijlstra
2018-06-06 18:37 ` Steven Rostedt
2018-06-06 18:59 ` Arnaldo Carvalho de Melo [this message]
2018-06-06 19:13 ` Steven Rostedt
2018-06-06 19:47 ` Arnaldo Carvalho de Melo
2018-08-18 11:59 ` [tip:perf/urgent] " tip-bot for Adrian Hunter
2018-06-06 12:54 ` [PATCH V4 2/3] kallsyms, x86: Export addresses of PTI entry trampolines Adrian Hunter
2018-06-06 13:14 ` Peter Zijlstra
2018-08-18 11:59 ` [tip:perf/urgent] " tip-bot for Alexander Shishkin
2018-06-06 12:54 ` [PATCH V4 3/3] x86: Add entry trampolines to kcore Adrian Hunter
2018-06-06 13:16 ` Peter Zijlstra
2018-06-06 13:19 ` Arnaldo Carvalho de Melo
2018-07-17 8:54 ` Adrian Hunter
2018-07-17 14:47 ` Arnaldo Carvalho de Melo
2018-08-18 12:00 ` [tip:perf/urgent] " tip-bot for Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180606185914.GJ24381@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=daniel@iogearbox.net \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).