The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Mathieu Malaterre <malat@debian.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Mathieu Malaterre <malat@debian.org>,
	Babu Moger <babu.moger@oracle.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] kernel/watchdog: add missing prototypes for weak functions
Date: Wed,  6 Jun 2018 21:42:32 +0200	[thread overview]
Message-ID: <20180606194232.17653-1-malat@debian.org> (raw)

In commit 73ce0511c436 ("kernel/watchdog.c: move hardlockup detector to
separate file") two new functions were added ‘watchdog_nmi_enable’ and
‘watchdog_nmi_disable’ the functions were changed from static to weak.
In which case expose the function declarations in header file.

Silence the following gcc warnings:

  kernel/watchdog.c:109:12: warning: no previous prototype for ‘watchdog_nmi_enable’ [-Wmissing-prototypes]
  kernel/watchdog.c:115:13: warning: no previous prototype for ‘watchdog_nmi_disable’ [-Wmissing-prototypes]

Cc: Babu Moger <babu.moger@oracle.com>
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
 include/linux/nmi.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/nmi.h b/include/linux/nmi.h
index b8d868d23e79..50d143995338 100644
--- a/include/linux/nmi.h
+++ b/include/linux/nmi.h
@@ -113,6 +113,8 @@ static inline int hardlockup_detector_perf_init(void) { return 0; }
 void watchdog_nmi_stop(void);
 void watchdog_nmi_start(void);
 int watchdog_nmi_probe(void);
+int watchdog_nmi_enable(unsigned int cpu);
+void watchdog_nmi_disable(unsigned int cpu);
 
 /**
  * touch_nmi_watchdog - restart NMI watchdog timeout.
-- 
2.11.0

             reply	other threads:[~2018-06-06 19:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-06 19:42 Mathieu Malaterre [this message]
2018-11-06 20:35 ` [PATCH] kernel/watchdog: add missing prototypes for weak functions Mathieu Malaterre
2018-11-06 22:21 ` [tip:core/urgent] watchdog/core: Add " tip-bot for Mathieu Malaterre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180606194232.17653-1-malat@debian.org \
    --to=malat@debian.org \
    --cc=babu.moger@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox