From: Masami Hiramatsu <mhiramat@kernel.org>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH] selftests/ftrace: Add ppc support for kprobe args tests
Date: Wed, 6 Jun 2018 20:37:52 +0900 [thread overview]
Message-ID: <20180606203752.7768487691f4a85a56f82978@kernel.org> (raw)
In-Reply-To: <20180606093154.10408-1-naveen.n.rao@linux.vnet.ibm.com>
On Wed, 6 Jun 2018 15:01:54 +0530
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:
> Add powerpc support for the recently added kprobe args tests.
Thank you for adding powerpc support!
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
>
> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> ---
> .../selftests/ftrace/test.d/kprobe/kprobe_args_string.tc | 8 ++++++++
> .../selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc | 7 +++++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> index 5ba73035e1d9..a0002563e9ee 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> @@ -24,6 +24,14 @@ arm*)
> ARG2=%r1
> OFFS=4
> ;;
> +ppc64*)
> + ARG2=%r4
> + OFFS=8
> +;;
> +ppc*)
> + ARG2=%r4
> + OFFS=4
> +;;
> *)
> echo "Please implement other architecture here"
> exit_untested
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> index 231bcd2c4eb5..d026ff4e562f 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> @@ -34,6 +34,13 @@ arm*)
> GOODREG=%r0
> BADREG=%ax
> ;;
> +ppc*)
> + GOODREG=%r3
> + BADREG=%msr
> +;;
> +*)
> + echo "Please implement other architecture here"
> + exit_untested
> esac
>
> test_goodarg() # Good-args
> --
> 2.17.0
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2018-06-06 11:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 9:31 [PATCH] selftests/ftrace: Add ppc support for kprobe args tests Naveen N. Rao
2018-06-06 11:37 ` Masami Hiramatsu [this message]
2018-06-06 17:20 ` Steven Rostedt
2018-06-06 19:38 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180606203752.7768487691f4a85a56f82978@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox