From: John Whitmore <arigead@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: John Whitmore <johnfwhitmore@gmail.com>,
linux-kernel@vger.kernel.org, kstewart@linuxfoundation.org,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
colin.king@canonical.com, tglx@linutronix.de
Subject: Re: [PATCH v6 8/8] staging: rtl8192e: remove unnecessary parentheses - Coding Style
Date: Fri, 8 Jun 2018 14:01:29 +0100 [thread overview]
Message-ID: <20180608130127.koojqozbasmef2gd@linux-08lc> (raw)
In-Reply-To: <20180608121851.o7m3iihg2ibbgmxh@mwanda>
On Fri, Jun 08, 2018 at 03:18:51PM +0300, Dan Carpenter wrote:
> On Wed, Jun 06, 2018 at 12:40:03PM +0100, John Whitmore wrote:
> > @@ -1072,10 +1072,10 @@ void HTInitializeHTInfo(struct ieee80211_device *ieee)
> > pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
> >
> > // Initialize all of the parameters related to 11n
> > - memset((void *)(&(pHTInfo->SelfHTCap)), 0, sizeof(pHTInfo->SelfHTCap));
> > - memset((void *)(&(pHTInfo->SelfHTInfo)), 0, sizeof(pHTInfo->SelfHTInfo));
> > - memset((void *)(&(pHTInfo->PeerHTCapBuf)), 0, sizeof(pHTInfo->PeerHTCapBuf));
> > - memset((void *)(&(pHTInfo->PeerHTInfoBuf)), 0, sizeof(pHTInfo->PeerHTInfoBuf));
> > + memset((void *)(&pHTInfo->SelfHTCap), 0, sizeof(pHTInfo->SelfHTCap));
> > + memset((void *)(&pHTInfo->SelfHTInfo), 0, sizeof(pHTInfo->SelfHTInfo));
> > + memset((void *)(&pHTInfo->PeerHTCapBuf), 0, sizeof(pHTInfo->PeerHTCapBuf));
> > + memset((void *)(&pHTInfo->PeerHTInfoBuf), 0, sizeof(pHTInfo->PeerHTInfoBuf));
>
> You should write these like so:
>
> memset(&pHTInfo->PeerHTInfoBuf, 0, sizeof(pHTInfo->PeerHTInfoBuf));
>
> The first 7 patches look fine, but can you resend this last one?
>
> regards,
> dan carpenter
>
I can certainly try. I've bumped it to v7 so here goes...
John
next prev parent reply other threads:[~2018-06-08 13:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 11:39 staging: rtl8192e: Series of coding style changes John Whitmore
2018-06-06 11:39 ` [PATCH v6 1/8] staging: rtl8192e: Add and remove blank lines - Coding style John Whitmore
2018-06-06 11:39 ` [PATCH v6 2/8] staging: rtl8192e: Addition of prefered spacing " John Whitmore
2018-06-06 11:39 ` [PATCH v6 3/8] staging: rtl8192e: Remove unnecessary return statements " John Whitmore
2018-06-06 11:39 ` [PATCH v6 4/8] staging: rtl8192e: Correct alignment of if statements - Coding Style John Whitmore
2018-06-06 11:40 ` [PATCH v6 5/8] staging: rtl8192e: Remove unrequired space at start of line " John Whitmore
2018-06-06 11:40 ` [PATCH v6 6/8] staging: rtl8192e: Correct declaration of HTResetIOTSetting " John Whitmore
2018-06-06 11:40 ` [PATCH v6 7/8] staging: rtl8192e: Optimise Comparison to NULL tests " John Whitmore
2018-06-06 11:40 ` [PATCH v6 8/8] staging: rtl8192e: remove unnecessary parentheses " John Whitmore
2018-06-08 12:18 ` Dan Carpenter
2018-06-08 13:01 ` John Whitmore [this message]
2018-06-06 12:19 ` staging: rtl8192e: Series of coding style changes Justin Skists
2018-06-15 17:42 ` John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608130127.koojqozbasmef2gd@linux-08lc \
--to=arigead@gmail.com \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnfwhitmore@gmail.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox