From: Lee Jones <lee.jones@linaro.org>
To: Benson Leung <bleung@google.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Gwendal Grignou <gwendal@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Benson Leung <bleung@chromium.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: cros_ec: remove unused __remove function
Date: Mon, 11 Jun 2018 07:08:19 +0100 [thread overview]
Message-ID: <20180611060819.GD5278@dell> (raw)
In-Reply-To: <20180608181956.GA110395@decatoncale.mtv.corp.google.com>
On Fri, 08 Jun 2018, Benson Leung wrote:
>
> On Fri, Jun 08, 2018 at 04:48:06PM +0200, Arnd Bergmann wrote:
> > This function is no longer called, so we get a harmless
> > warning until it is removed as well:
> >
> > drivers/mfd/cros_ec_dev.c:265:13: error: '__remove' defined but not used [-Werror=unused-function]
> >
> > Fixes: 3aa2177e4787 ("mfd: cros_ec: Use devm_kzalloc for private data")
>
> Gwendal, in PATCH v2 of https://patchwork.kernel.org/patch/10439449/
> you mentioned that you readded the __remove to avoid a warning when built
> as a module. Can you explain what's going on?
Yes please, and quickly. I'm going to sent the patch-set today. If I
don't hear from you promptly, I'll probably pull the patch!
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-06-11 6:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 14:48 [PATCH] mfd: cros_ec: remove unused __remove function Arnd Bergmann
2018-06-08 18:19 ` Benson Leung
2018-06-11 6:08 ` Lee Jones [this message]
2018-06-12 19:53 ` Gwendal Grignou
2018-06-13 5:45 ` Lee Jones
2018-06-14 10:35 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611060819.GD5278@dell \
--to=lee.jones@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=bleung@chromium.org \
--cc=bleung@google.com \
--cc=enric.balletbo@collabora.com \
--cc=gwendal@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox