* [PATCH v1] aio: mark __aio_sigset::sigmask const
@ 2018-06-08 14:55 Avi Kivity
2018-06-11 6:56 ` Christoph Hellwig
2018-06-14 12:16 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Avi Kivity @ 2018-06-08 14:55 UTC (permalink / raw)
To: Alexander Viro
Cc: Benjamin LaHaise, linux-fsdevel, linux-aio, linux-kernel, hch
io_pgetevents() will not change the signal mask. Mark it const
to make it clear and to reduce the need for casts in user code.
Signed-off-by: Avi Kivity <avi@scylladb.com>
---
include/uapi/linux/aio_abi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/aio_abi.h b/include/uapi/linux/aio_abi.h
index ed0185945bb2..cdf115b03761 100644
--- a/include/uapi/linux/aio_abi.h
+++ b/include/uapi/linux/aio_abi.h
@@ -106,11 +106,11 @@ struct iocb {
#undef IFBIG
#undef IFLITTLE
struct __aio_sigset {
- sigset_t __user *sigmask;
+ const sigset_t __user *sigmask;
size_t sigsetsize;
};
#endif /* __LINUX__AIO_ABI_H */
--
2.14.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] aio: mark __aio_sigset::sigmask const
2018-06-08 14:55 [PATCH v1] aio: mark __aio_sigset::sigmask const Avi Kivity
@ 2018-06-11 6:56 ` Christoph Hellwig
2018-06-14 12:16 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2018-06-11 6:56 UTC (permalink / raw)
To: Avi Kivity
Cc: Alexander Viro, Benjamin LaHaise, linux-fsdevel, linux-aio,
linux-kernel, hch
On Fri, Jun 08, 2018 at 05:55:05PM +0300, Avi Kivity wrote:
> io_pgetevents() will not change the signal mask. Mark it const
> to make it clear and to reduce the need for casts in user code.
>
> Signed-off-by: Avi Kivity <avi@scylladb.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] aio: mark __aio_sigset::sigmask const
2018-06-08 14:55 [PATCH v1] aio: mark __aio_sigset::sigmask const Avi Kivity
2018-06-11 6:56 ` Christoph Hellwig
@ 2018-06-14 12:16 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2018-06-14 12:16 UTC (permalink / raw)
To: Alexander Viro, Avi Kivity, Benjamin LaHaise, linux-fsdevel,
linux-aio, linux-kernel, hch
On Fri, Jun 08, 2018 at 05:55:05PM +0300, Avi Kivity wrote:
> io_pgetevents() will not change the signal mask. Mark it const
> to make it clear and to reduce the need for casts in user code.
>
> Signed-off-by: Avi Kivity <avi@scylladb.com>
Al, can you pick this one and the masking fix before -rc1?
> ---
> include/uapi/linux/aio_abi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/aio_abi.h b/include/uapi/linux/aio_abi.h
> index ed0185945bb2..cdf115b03761 100644
> --- a/include/uapi/linux/aio_abi.h
> +++ b/include/uapi/linux/aio_abi.h
> @@ -106,11 +106,11 @@ struct iocb {
>
> #undef IFBIG
> #undef IFLITTLE
>
> struct __aio_sigset {
> - sigset_t __user *sigmask;
> + const sigset_t __user *sigmask;
> size_t sigsetsize;
> };
>
> #endif /* __LINUX__AIO_ABI_H */
>
> --
> 2.14.4
---end quoted text---
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-14 12:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-08 14:55 [PATCH v1] aio: mark __aio_sigset::sigmask const Avi Kivity
2018-06-11 6:56 ` Christoph Hellwig
2018-06-14 12:16 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox