* [PATCH v4 1/2] media: staging/imx: fill vb2_v4l2_buffer field entry
@ 2018-03-15 19:13 Peter Seiderer
2018-03-15 19:13 ` [PATCH v4 2/2] media: staging/imx: fill vb2_v4l2_buffer sequence entry Peter Seiderer
2018-03-16 17:02 ` [PATCH v4 1/2] media: staging/imx: fill vb2_v4l2_buffer field entry Steve Longerbeam
0 siblings, 2 replies; 9+ messages in thread
From: Peter Seiderer @ 2018-03-15 19:13 UTC (permalink / raw)
To: linux-media
Cc: devel, Greg Kroah-Hartman, linux-kernel, Peter Seiderer,
Philipp Zabel, Steve Longerbeam, Mauro Carvalho Chehab
- fixes gstreamer v4l2src warning:
0:00:00.716640334 349 0x164f720 WARN v4l2bufferpool gstv4l2bufferpool.c:1195:gst_v4l2_buffer_pool_dqbuf:<v4l2src0:pool:src> Driver should never set v4l2_buffer.field to ANY
- fixes v4l2-compliance test failure:
Streaming ioctls:
test read/write: OK (Not Supported)
Video Capture:
Buffer: 0 Sequence: 0 Field: Any Timestamp: 58.383658s
fail: v4l2-test-buffers.cpp(297): g_field() == V4L2_FIELD_ANY
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Changes in v4:
- new patch (put first because patch is needed to advance with
the v4l2-compliance test), thanks to Philipp Zabel
<p.zabel@pengutronix.de> for suggested solution for the right
field value source
---
drivers/staging/media/imx/imx-ic-prpencvf.c | 1 +
drivers/staging/media/imx/imx-media-csi.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c b/drivers/staging/media/imx/imx-ic-prpencvf.c
index ae453fd422f0..ffeb017c73b2 100644
--- a/drivers/staging/media/imx/imx-ic-prpencvf.c
+++ b/drivers/staging/media/imx/imx-ic-prpencvf.c
@@ -210,6 +210,7 @@ static void prp_vb2_buf_done(struct prp_priv *priv, struct ipuv3_channel *ch)
done = priv->active_vb2_buf[priv->ipu_buf_num];
if (done) {
+ done->vbuf.field = vdev->fmt.fmt.pix.field;
vb = &done->vbuf.vb2_buf;
vb->timestamp = ktime_get_ns();
vb2_buffer_done(vb, priv->nfb4eof ?
diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
index 5a195f80a24d..5f69117b5811 100644
--- a/drivers/staging/media/imx/imx-media-csi.c
+++ b/drivers/staging/media/imx/imx-media-csi.c
@@ -236,6 +236,7 @@ static void csi_vb2_buf_done(struct csi_priv *priv)
done = priv->active_vb2_buf[priv->ipu_buf_num];
if (done) {
+ done->vbuf.field = vdev->fmt.fmt.pix.field;
vb = &done->vbuf.vb2_buf;
vb->timestamp = ktime_get_ns();
vb2_buffer_done(vb, priv->nfb4eof ?
--
2.16.2
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v4 2/2] media: staging/imx: fill vb2_v4l2_buffer sequence entry 2018-03-15 19:13 [PATCH v4 1/2] media: staging/imx: fill vb2_v4l2_buffer field entry Peter Seiderer @ 2018-03-15 19:13 ` Peter Seiderer 2018-03-16 8:12 ` Dan Carpenter 2018-03-16 17:05 ` Steve Longerbeam 2018-03-16 17:02 ` [PATCH v4 1/2] media: staging/imx: fill vb2_v4l2_buffer field entry Steve Longerbeam 1 sibling, 2 replies; 9+ messages in thread From: Peter Seiderer @ 2018-03-15 19:13 UTC (permalink / raw) To: linux-media Cc: devel, Greg Kroah-Hartman, linux-kernel, Peter Seiderer, Philipp Zabel, Steve Longerbeam, Mauro Carvalho Chehab - enables gstreamer v4l2src lost frame detection, e.g: 0:00:08.685185668 348 0x54f520 WARN v4l2src gstv4l2src.c:970:gst_v4l2src_create:<v4l2src0> lost frames detected: count = 141 - ts: 0:00:08.330177332 - fixes v4l2-compliance test failure: Streaming ioctls: test read/write: OK (Not Supported) Video Capture: Buffer: 0 Sequence: 0 Field: None Timestamp: 92.991450s Buffer: 1 Sequence: 0 Field: None Timestamp: 93.008135s fail: v4l2-test-buffers.cpp(294): (int)g_sequence() < seq.last_seq + 1 fail: v4l2-test-buffers.cpp(707): buf.check(q, last_seq) Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- Changes in v2: - fill vb2_v4l2_buffer sequence entry in imx-ic-prpencvf too (suggested by Steve Longerbeam) Changes in v3: - add changelog (suggested by Greg Kroah-Hartman, Fabio Estevam and Dan Carpenter) and patch history - use u32 (instead of __u32) (suggested by Dan Carpenter) - let sequence counter start with zero, keeping v4l2-compliance testing happy (needs additional setting of field to a valid value, patch will follow soon) Changes in v4: - add v4l2-compliance test failure to changelog - reorder frame_sequence increment and assignement to avoid -1 as start value (suggeted by Steve Longerbeam) --- drivers/staging/media/imx/imx-ic-prpencvf.c | 4 ++++ drivers/staging/media/imx/imx-media-csi.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c b/drivers/staging/media/imx/imx-ic-prpencvf.c index ffeb017c73b2..28f41caba05d 100644 --- a/drivers/staging/media/imx/imx-ic-prpencvf.c +++ b/drivers/staging/media/imx/imx-ic-prpencvf.c @@ -103,6 +103,7 @@ struct prp_priv { int nfb4eof_irq; int stream_count; + u32 frame_sequence; /* frame sequence counter */ bool last_eof; /* waiting for last EOF at stream off */ bool nfb4eof; /* NFB4EOF encountered during streaming */ struct completion last_eof_comp; @@ -211,12 +212,14 @@ static void prp_vb2_buf_done(struct prp_priv *priv, struct ipuv3_channel *ch) done = priv->active_vb2_buf[priv->ipu_buf_num]; if (done) { done->vbuf.field = vdev->fmt.fmt.pix.field; + done->vbuf.sequence = priv->frame_sequence; vb = &done->vbuf.vb2_buf; vb->timestamp = ktime_get_ns(); vb2_buffer_done(vb, priv->nfb4eof ? VB2_BUF_STATE_ERROR : VB2_BUF_STATE_DONE); } + priv->frame_sequence++; priv->nfb4eof = false; /* get next queued buffer */ @@ -638,6 +641,7 @@ static int prp_start(struct prp_priv *priv) /* init EOF completion waitq */ init_completion(&priv->last_eof_comp); + priv->frame_sequence = 0; priv->last_eof = false; priv->nfb4eof = false; diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c index 5f69117b5811..3f2ce05848f3 100644 --- a/drivers/staging/media/imx/imx-media-csi.c +++ b/drivers/staging/media/imx/imx-media-csi.c @@ -111,6 +111,7 @@ struct csi_priv { struct v4l2_ctrl_handler ctrl_hdlr; int stream_count; /* streaming counter */ + u32 frame_sequence; /* frame sequence counter */ bool last_eof; /* waiting for last EOF at stream off */ bool nfb4eof; /* NFB4EOF encountered during streaming */ struct completion last_eof_comp; @@ -237,12 +238,14 @@ static void csi_vb2_buf_done(struct csi_priv *priv) done = priv->active_vb2_buf[priv->ipu_buf_num]; if (done) { done->vbuf.field = vdev->fmt.fmt.pix.field; + done->vbuf.sequence = priv->frame_sequence; vb = &done->vbuf.vb2_buf; vb->timestamp = ktime_get_ns(); vb2_buffer_done(vb, priv->nfb4eof ? VB2_BUF_STATE_ERROR : VB2_BUF_STATE_DONE); } + priv->frame_sequence++; priv->nfb4eof = false; /* get next queued buffer */ @@ -544,6 +547,7 @@ static int csi_idmac_start(struct csi_priv *priv) /* init EOF completion waitq */ init_completion(&priv->last_eof_comp); + priv->frame_sequence = 0; priv->last_eof = false; priv->nfb4eof = false; -- 2.16.2 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v4 2/2] media: staging/imx: fill vb2_v4l2_buffer sequence entry 2018-03-15 19:13 ` [PATCH v4 2/2] media: staging/imx: fill vb2_v4l2_buffer sequence entry Peter Seiderer @ 2018-03-16 8:12 ` Dan Carpenter 2018-03-16 17:05 ` Steve Longerbeam 1 sibling, 0 replies; 9+ messages in thread From: Dan Carpenter @ 2018-03-16 8:12 UTC (permalink / raw) To: Peter Seiderer Cc: linux-media, devel, Greg Kroah-Hartman, linux-kernel, Philipp Zabel, Steve Longerbeam, Mauro Carvalho Chehab MUCH BETTER!111!Exclamationmark! Thanks! :) regards, dan carpenter ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 2/2] media: staging/imx: fill vb2_v4l2_buffer sequence entry 2018-03-15 19:13 ` [PATCH v4 2/2] media: staging/imx: fill vb2_v4l2_buffer sequence entry Peter Seiderer 2018-03-16 8:12 ` Dan Carpenter @ 2018-03-16 17:05 ` Steve Longerbeam 2018-06-11 20:48 ` Peter Seiderer 1 sibling, 1 reply; 9+ messages in thread From: Steve Longerbeam @ 2018-03-16 17:05 UTC (permalink / raw) To: Peter Seiderer, linux-media Cc: devel, Greg Kroah-Hartman, linux-kernel, Philipp Zabel, Steve Longerbeam, Mauro Carvalho Chehab Reviewed-by: Steve Longerbeam <steve_longerbeam@mentor.com> On 03/15/2018 12:13 PM, Peter Seiderer wrote: > - enables gstreamer v4l2src lost frame detection, e.g: > > 0:00:08.685185668 348 0x54f520 WARN v4l2src gstv4l2src.c:970:gst_v4l2src_create:<v4l2src0> lost frames detected: count = 141 - ts: 0:00:08.330177332 > > - fixes v4l2-compliance test failure: > > Streaming ioctls: > test read/write: OK (Not Supported) > Video Capture: > Buffer: 0 Sequence: 0 Field: None Timestamp: 92.991450s > Buffer: 1 Sequence: 0 Field: None Timestamp: 93.008135s > fail: v4l2-test-buffers.cpp(294): (int)g_sequence() < seq.last_seq + 1 > fail: v4l2-test-buffers.cpp(707): buf.check(q, last_seq) > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> > --- > Changes in v2: > - fill vb2_v4l2_buffer sequence entry in imx-ic-prpencvf too > (suggested by Steve Longerbeam) > > Changes in v3: > - add changelog (suggested by Greg Kroah-Hartman, Fabio Estevam > and Dan Carpenter) and patch history > - use u32 (instead of __u32) (suggested by Dan Carpenter) > - let sequence counter start with zero, keeping v4l2-compliance > testing happy (needs additional setting of field to a valid > value, patch will follow soon) > > Changes in v4: > - add v4l2-compliance test failure to changelog > - reorder frame_sequence increment and assignement to > avoid -1 as start value (suggeted by Steve Longerbeam) > --- > drivers/staging/media/imx/imx-ic-prpencvf.c | 4 ++++ > drivers/staging/media/imx/imx-media-csi.c | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c b/drivers/staging/media/imx/imx-ic-prpencvf.c > index ffeb017c73b2..28f41caba05d 100644 > --- a/drivers/staging/media/imx/imx-ic-prpencvf.c > +++ b/drivers/staging/media/imx/imx-ic-prpencvf.c > @@ -103,6 +103,7 @@ struct prp_priv { > int nfb4eof_irq; > > int stream_count; > + u32 frame_sequence; /* frame sequence counter */ > bool last_eof; /* waiting for last EOF at stream off */ > bool nfb4eof; /* NFB4EOF encountered during streaming */ > struct completion last_eof_comp; > @@ -211,12 +212,14 @@ static void prp_vb2_buf_done(struct prp_priv *priv, struct ipuv3_channel *ch) > done = priv->active_vb2_buf[priv->ipu_buf_num]; > if (done) { > done->vbuf.field = vdev->fmt.fmt.pix.field; > + done->vbuf.sequence = priv->frame_sequence; > vb = &done->vbuf.vb2_buf; > vb->timestamp = ktime_get_ns(); > vb2_buffer_done(vb, priv->nfb4eof ? > VB2_BUF_STATE_ERROR : VB2_BUF_STATE_DONE); > } > > + priv->frame_sequence++; > priv->nfb4eof = false; > > /* get next queued buffer */ > @@ -638,6 +641,7 @@ static int prp_start(struct prp_priv *priv) > > /* init EOF completion waitq */ > init_completion(&priv->last_eof_comp); > + priv->frame_sequence = 0; > priv->last_eof = false; > priv->nfb4eof = false; > > diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c > index 5f69117b5811..3f2ce05848f3 100644 > --- a/drivers/staging/media/imx/imx-media-csi.c > +++ b/drivers/staging/media/imx/imx-media-csi.c > @@ -111,6 +111,7 @@ struct csi_priv { > struct v4l2_ctrl_handler ctrl_hdlr; > > int stream_count; /* streaming counter */ > + u32 frame_sequence; /* frame sequence counter */ > bool last_eof; /* waiting for last EOF at stream off */ > bool nfb4eof; /* NFB4EOF encountered during streaming */ > struct completion last_eof_comp; > @@ -237,12 +238,14 @@ static void csi_vb2_buf_done(struct csi_priv *priv) > done = priv->active_vb2_buf[priv->ipu_buf_num]; > if (done) { > done->vbuf.field = vdev->fmt.fmt.pix.field; > + done->vbuf.sequence = priv->frame_sequence; > vb = &done->vbuf.vb2_buf; > vb->timestamp = ktime_get_ns(); > vb2_buffer_done(vb, priv->nfb4eof ? > VB2_BUF_STATE_ERROR : VB2_BUF_STATE_DONE); > } > > + priv->frame_sequence++; > priv->nfb4eof = false; > > /* get next queued buffer */ > @@ -544,6 +547,7 @@ static int csi_idmac_start(struct csi_priv *priv) > > /* init EOF completion waitq */ > init_completion(&priv->last_eof_comp); > + priv->frame_sequence = 0; > priv->last_eof = false; > priv->nfb4eof = false; > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 2/2] media: staging/imx: fill vb2_v4l2_buffer sequence entry 2018-03-16 17:05 ` Steve Longerbeam @ 2018-06-11 20:48 ` Peter Seiderer 2018-06-12 8:41 ` Philipp Zabel 0 siblings, 1 reply; 9+ messages in thread From: Peter Seiderer @ 2018-06-11 20:48 UTC (permalink / raw) To: Steve Longerbeam Cc: linux-media, Philipp Zabel, Mauro Carvalho Chehab, Greg Kroah-Hartman, devel, linux-kernel Hello *, On Fri, 16 Mar 2018 10:05:44 -0700, Steve Longerbeam <slongerbeam@gmail.com> wrote: > Reviewed-by: Steve Longerbeam <steve_longerbeam@mentor.com> Ping? Anybody taking this one? Regards, Peter > > > On 03/15/2018 12:13 PM, Peter Seiderer wrote: > > - enables gstreamer v4l2src lost frame detection, e.g: > > > > 0:00:08.685185668 348 0x54f520 WARN v4l2src gstv4l2src.c:970:gst_v4l2src_create:<v4l2src0> lost frames detected: count = 141 - ts: 0:00:08.330177332 > > > > - fixes v4l2-compliance test failure: > > > > Streaming ioctls: > > test read/write: OK (Not Supported) > > Video Capture: > > Buffer: 0 Sequence: 0 Field: None Timestamp: 92.991450s > > Buffer: 1 Sequence: 0 Field: None Timestamp: 93.008135s > > fail: v4l2-test-buffers.cpp(294): (int)g_sequence() < seq.last_seq + 1 > > fail: v4l2-test-buffers.cpp(707): buf.check(q, last_seq) > > > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> > > --- > > Changes in v2: > > - fill vb2_v4l2_buffer sequence entry in imx-ic-prpencvf too > > (suggested by Steve Longerbeam) > > > > Changes in v3: > > - add changelog (suggested by Greg Kroah-Hartman, Fabio Estevam > > and Dan Carpenter) and patch history > > - use u32 (instead of __u32) (suggested by Dan Carpenter) > > - let sequence counter start with zero, keeping v4l2-compliance > > testing happy (needs additional setting of field to a valid > > value, patch will follow soon) > > > > Changes in v4: > > - add v4l2-compliance test failure to changelog > > - reorder frame_sequence increment and assignement to > > avoid -1 as start value (suggeted by Steve Longerbeam) > > --- > > drivers/staging/media/imx/imx-ic-prpencvf.c | 4 ++++ > > drivers/staging/media/imx/imx-media-csi.c | 4 ++++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c b/drivers/staging/media/imx/imx-ic-prpencvf.c > > index ffeb017c73b2..28f41caba05d 100644 > > --- a/drivers/staging/media/imx/imx-ic-prpencvf.c > > +++ b/drivers/staging/media/imx/imx-ic-prpencvf.c > > @@ -103,6 +103,7 @@ struct prp_priv { > > int nfb4eof_irq; > > > > int stream_count; > > + u32 frame_sequence; /* frame sequence counter */ > > bool last_eof; /* waiting for last EOF at stream off */ > > bool nfb4eof; /* NFB4EOF encountered during streaming */ > > struct completion last_eof_comp; > > @@ -211,12 +212,14 @@ static void prp_vb2_buf_done(struct prp_priv *priv, struct ipuv3_channel *ch) > > done = priv->active_vb2_buf[priv->ipu_buf_num]; > > if (done) { > > done->vbuf.field = vdev->fmt.fmt.pix.field; > > + done->vbuf.sequence = priv->frame_sequence; > > vb = &done->vbuf.vb2_buf; > > vb->timestamp = ktime_get_ns(); > > vb2_buffer_done(vb, priv->nfb4eof ? > > VB2_BUF_STATE_ERROR : VB2_BUF_STATE_DONE); > > } > > > > + priv->frame_sequence++; > > priv->nfb4eof = false; > > > > /* get next queued buffer */ > > @@ -638,6 +641,7 @@ static int prp_start(struct prp_priv *priv) > > > > /* init EOF completion waitq */ > > init_completion(&priv->last_eof_comp); > > + priv->frame_sequence = 0; > > priv->last_eof = false; > > priv->nfb4eof = false; > > > > diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c > > index 5f69117b5811..3f2ce05848f3 100644 > > --- a/drivers/staging/media/imx/imx-media-csi.c > > +++ b/drivers/staging/media/imx/imx-media-csi.c > > @@ -111,6 +111,7 @@ struct csi_priv { > > struct v4l2_ctrl_handler ctrl_hdlr; > > > > int stream_count; /* streaming counter */ > > + u32 frame_sequence; /* frame sequence counter */ > > bool last_eof; /* waiting for last EOF at stream off */ > > bool nfb4eof; /* NFB4EOF encountered during streaming */ > > struct completion last_eof_comp; > > @@ -237,12 +238,14 @@ static void csi_vb2_buf_done(struct csi_priv *priv) > > done = priv->active_vb2_buf[priv->ipu_buf_num]; > > if (done) { > > done->vbuf.field = vdev->fmt.fmt.pix.field; > > + done->vbuf.sequence = priv->frame_sequence; > > vb = &done->vbuf.vb2_buf; > > vb->timestamp = ktime_get_ns(); > > vb2_buffer_done(vb, priv->nfb4eof ? > > VB2_BUF_STATE_ERROR : VB2_BUF_STATE_DONE); > > } > > > > + priv->frame_sequence++; > > priv->nfb4eof = false; > > > > /* get next queued buffer */ > > @@ -544,6 +547,7 @@ static int csi_idmac_start(struct csi_priv *priv) > > > > /* init EOF completion waitq */ > > init_completion(&priv->last_eof_comp); > > + priv->frame_sequence = 0; > > priv->last_eof = false; > > priv->nfb4eof = false; > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 2/2] media: staging/imx: fill vb2_v4l2_buffer sequence entry 2018-06-11 20:48 ` Peter Seiderer @ 2018-06-12 8:41 ` Philipp Zabel 2018-06-12 8:59 ` Hans Verkuil 0 siblings, 1 reply; 9+ messages in thread From: Philipp Zabel @ 2018-06-12 8:41 UTC (permalink / raw) To: Peter Seiderer, Mauro Carvalho Chehab, Steve Longerbeam Cc: linux-media, Greg Kroah-Hartman, devel, linux-kernel Hi, On Mon, 2018-06-11 at 22:48 +0200, Peter Seiderer wrote: > Hello *, > > On Fri, 16 Mar 2018 10:05:44 -0700, Steve Longerbeam <slongerbeam@gmail.com> wrote: > > > Reviewed-by: Steve Longerbeam <steve_longerbeam@mentor.com> > > Ping? Anybody taking this one? The patches have been marked not applicable in patchwork [1][2]. They do apply on media_tree master. [1] https://patchwork.linuxtv.org/patch/47946/ [2] https://patchwork.linuxtv.org/patch/47947/ regards Philipp ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 2/2] media: staging/imx: fill vb2_v4l2_buffer sequence entry 2018-06-12 8:41 ` Philipp Zabel @ 2018-06-12 8:59 ` Hans Verkuil 0 siblings, 0 replies; 9+ messages in thread From: Hans Verkuil @ 2018-06-12 8:59 UTC (permalink / raw) To: Philipp Zabel, Peter Seiderer, Mauro Carvalho Chehab, Steve Longerbeam Cc: linux-media, Greg Kroah-Hartman, devel, linux-kernel On 12/06/18 10:41, Philipp Zabel wrote: > Hi, > > On Mon, 2018-06-11 at 22:48 +0200, Peter Seiderer wrote: >> Hello *, >> >> On Fri, 16 Mar 2018 10:05:44 -0700, Steve Longerbeam <slongerbeam@gmail.com> wrote: >> >>> Reviewed-by: Steve Longerbeam <steve_longerbeam@mentor.com> >> >> Ping? Anybody taking this one? > > The patches have been marked not applicable in patchwork [1][2]. > They do apply on media_tree master. > > [1] https://patchwork.linuxtv.org/patch/47946/ > [2] https://patchwork.linuxtv.org/patch/47947/ > > regards > Philipp > I changed the state to NEW and delegated it to me, so the next time I'm processing patches I'll handled them. I suspect the state was changed by mistake by someone (quite possibly me!). Regards, Hans ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 1/2] media: staging/imx: fill vb2_v4l2_buffer field entry 2018-03-15 19:13 [PATCH v4 1/2] media: staging/imx: fill vb2_v4l2_buffer field entry Peter Seiderer 2018-03-15 19:13 ` [PATCH v4 2/2] media: staging/imx: fill vb2_v4l2_buffer sequence entry Peter Seiderer @ 2018-03-16 17:02 ` Steve Longerbeam 2018-06-11 20:47 ` Peter Seiderer 1 sibling, 1 reply; 9+ messages in thread From: Steve Longerbeam @ 2018-03-16 17:02 UTC (permalink / raw) To: Peter Seiderer, linux-media Cc: devel, Greg Kroah-Hartman, Mauro Carvalho Chehab, linux-kernel, Philipp Zabel Reviewed-by: Steve Longerbeam <steve_longerbeam@mentor.com> On 03/15/2018 12:13 PM, Peter Seiderer wrote: > - fixes gstreamer v4l2src warning: > > 0:00:00.716640334 349 0x164f720 WARN v4l2bufferpool gstv4l2bufferpool.c:1195:gst_v4l2_buffer_pool_dqbuf:<v4l2src0:pool:src> Driver should never set v4l2_buffer.field to ANY > > - fixes v4l2-compliance test failure: > > Streaming ioctls: > test read/write: OK (Not Supported) > Video Capture: > Buffer: 0 Sequence: 0 Field: Any Timestamp: 58.383658s > fail: v4l2-test-buffers.cpp(297): g_field() == V4L2_FIELD_ANY > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> > --- > Changes in v4: > - new patch (put first because patch is needed to advance with > the v4l2-compliance test), thanks to Philipp Zabel > <p.zabel@pengutronix.de> for suggested solution for the right > field value source > --- > drivers/staging/media/imx/imx-ic-prpencvf.c | 1 + > drivers/staging/media/imx/imx-media-csi.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c b/drivers/staging/media/imx/imx-ic-prpencvf.c > index ae453fd422f0..ffeb017c73b2 100644 > --- a/drivers/staging/media/imx/imx-ic-prpencvf.c > +++ b/drivers/staging/media/imx/imx-ic-prpencvf.c > @@ -210,6 +210,7 @@ static void prp_vb2_buf_done(struct prp_priv *priv, struct ipuv3_channel *ch) > > done = priv->active_vb2_buf[priv->ipu_buf_num]; > if (done) { > + done->vbuf.field = vdev->fmt.fmt.pix.field; > vb = &done->vbuf.vb2_buf; > vb->timestamp = ktime_get_ns(); > vb2_buffer_done(vb, priv->nfb4eof ? > diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c > index 5a195f80a24d..5f69117b5811 100644 > --- a/drivers/staging/media/imx/imx-media-csi.c > +++ b/drivers/staging/media/imx/imx-media-csi.c > @@ -236,6 +236,7 @@ static void csi_vb2_buf_done(struct csi_priv *priv) > > done = priv->active_vb2_buf[priv->ipu_buf_num]; > if (done) { > + done->vbuf.field = vdev->fmt.fmt.pix.field; > vb = &done->vbuf.vb2_buf; > vb->timestamp = ktime_get_ns(); > vb2_buffer_done(vb, priv->nfb4eof ? _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 1/2] media: staging/imx: fill vb2_v4l2_buffer field entry 2018-03-16 17:02 ` [PATCH v4 1/2] media: staging/imx: fill vb2_v4l2_buffer field entry Steve Longerbeam @ 2018-06-11 20:47 ` Peter Seiderer 0 siblings, 0 replies; 9+ messages in thread From: Peter Seiderer @ 2018-06-11 20:47 UTC (permalink / raw) To: Steve Longerbeam Cc: linux-media, Philipp Zabel, Mauro Carvalho Chehab, Greg Kroah-Hartman, devel, linux-kernel Hello *, On Fri, 16 Mar 2018 10:02:47 -0700, Steve Longerbeam <slongerbeam@gmail.com> wrote: > Reviewed-by: Steve Longerbeam <steve_longerbeam@mentor.com> Ping? Anybody taking this one? Regards, Peter > > > On 03/15/2018 12:13 PM, Peter Seiderer wrote: > > - fixes gstreamer v4l2src warning: > > > > 0:00:00.716640334 349 0x164f720 WARN v4l2bufferpool gstv4l2bufferpool.c:1195:gst_v4l2_buffer_pool_dqbuf:<v4l2src0:pool:src> Driver should never set v4l2_buffer.field to ANY > > > > - fixes v4l2-compliance test failure: > > > > Streaming ioctls: > > test read/write: OK (Not Supported) > > Video Capture: > > Buffer: 0 Sequence: 0 Field: Any Timestamp: 58.383658s > > fail: v4l2-test-buffers.cpp(297): g_field() == V4L2_FIELD_ANY > > > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> > > --- > > Changes in v4: > > - new patch (put first because patch is needed to advance with > > the v4l2-compliance test), thanks to Philipp Zabel > > <p.zabel@pengutronix.de> for suggested solution for the right > > field value source > > --- > > drivers/staging/media/imx/imx-ic-prpencvf.c | 1 + > > drivers/staging/media/imx/imx-media-csi.c | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c b/drivers/staging/media/imx/imx-ic-prpencvf.c > > index ae453fd422f0..ffeb017c73b2 100644 > > --- a/drivers/staging/media/imx/imx-ic-prpencvf.c > > +++ b/drivers/staging/media/imx/imx-ic-prpencvf.c > > @@ -210,6 +210,7 @@ static void prp_vb2_buf_done(struct prp_priv *priv, struct ipuv3_channel *ch) > > > > done = priv->active_vb2_buf[priv->ipu_buf_num]; > > if (done) { > > + done->vbuf.field = vdev->fmt.fmt.pix.field; > > vb = &done->vbuf.vb2_buf; > > vb->timestamp = ktime_get_ns(); > > vb2_buffer_done(vb, priv->nfb4eof ? > > diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c > > index 5a195f80a24d..5f69117b5811 100644 > > --- a/drivers/staging/media/imx/imx-media-csi.c > > +++ b/drivers/staging/media/imx/imx-media-csi.c > > @@ -236,6 +236,7 @@ static void csi_vb2_buf_done(struct csi_priv *priv) > > > > done = priv->active_vb2_buf[priv->ipu_buf_num]; > > if (done) { > > + done->vbuf.field = vdev->fmt.fmt.pix.field; > > vb = &done->vbuf.vb2_buf; > > vb->timestamp = ktime_get_ns(); > > vb2_buffer_done(vb, priv->nfb4eof ? > ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-06-12 8:59 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-03-15 19:13 [PATCH v4 1/2] media: staging/imx: fill vb2_v4l2_buffer field entry Peter Seiderer 2018-03-15 19:13 ` [PATCH v4 2/2] media: staging/imx: fill vb2_v4l2_buffer sequence entry Peter Seiderer 2018-03-16 8:12 ` Dan Carpenter 2018-03-16 17:05 ` Steve Longerbeam 2018-06-11 20:48 ` Peter Seiderer 2018-06-12 8:41 ` Philipp Zabel 2018-06-12 8:59 ` Hans Verkuil 2018-03-16 17:02 ` [PATCH v4 1/2] media: staging/imx: fill vb2_v4l2_buffer field entry Steve Longerbeam 2018-06-11 20:47 ` Peter Seiderer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox