From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>, Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-kernel@vger.kernel.org, jolsa@redhat.com,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: [PATCH v1 2/6] perf: Disable IRQs in address filter sync path
Date: Tue, 12 Jun 2018 10:51:13 +0300 [thread overview]
Message-ID: <20180612075117.65420-3-alexander.shishkin@linux.intel.com> (raw)
In-Reply-To: <20180612075117.65420-1-alexander.shishkin@linux.intel.com>
If PMU callbacks are executed in hardirq context, the address filter
sync code needs to disable interrupts when taking its spinlock, to be
consistent with the rest of its users. This may happen if the PMU is
used in AUX sampling or the PMI is delivered as a regular interrupt.
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
kernel/events/core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 0f5cd1b08dbd..e1fce335a42a 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -2601,16 +2601,17 @@ static int perf_event_stop(struct perf_event *event, int restart)
void perf_event_addr_filters_sync(struct perf_event *event)
{
struct perf_addr_filters_head *ifh = perf_event_addr_filters(event);
+ unsigned long flags;
if (!has_addr_filter(event))
return;
- raw_spin_lock(&ifh->lock);
+ raw_spin_lock_irqsave(&ifh->lock, flags);
if (event->addr_filters_gen != event->hw.addr_filters_gen) {
event->pmu->addr_filters_sync(event);
event->hw.addr_filters_gen = event->addr_filters_gen;
}
- raw_spin_unlock(&ifh->lock);
+ raw_spin_unlock_irqrestore(&ifh->lock, flags);
}
EXPORT_SYMBOL_GPL(perf_event_addr_filters_sync);
--
2.17.1
next prev parent reply other threads:[~2018-06-12 7:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 7:51 [PATCH v1 0/6] perf: Add AUX data sampling Alexander Shishkin
2018-06-12 7:51 ` [PATCH v1 1/6] perf: Disable PMU around address filter adjustment Alexander Shishkin
2018-06-12 20:11 ` Peter Zijlstra
2018-06-12 7:51 ` Alexander Shishkin [this message]
2018-06-12 7:51 ` [PATCH v1 3/6] perf: Add an iterator for AUX data Alexander Shishkin
2018-06-12 7:51 ` [PATCH v1 4/6] perf: Allow using AUX data in perf samples Alexander Shishkin
2018-06-14 19:25 ` Peter Zijlstra
2018-06-14 19:39 ` Peter Zijlstra
2018-06-19 10:51 ` Alexander Shishkin
2018-06-14 19:30 ` Peter Zijlstra
2018-06-14 19:47 ` Peter Zijlstra
2018-06-19 11:00 ` Alexander Shishkin
2018-06-14 20:03 ` Peter Zijlstra
2018-06-14 20:20 ` Peter Zijlstra
2018-06-19 10:47 ` Alexander Shishkin
2018-06-21 20:16 ` Peter Zijlstra
2018-10-02 14:00 ` Alexander Shishkin
2019-08-09 12:32 ` Alexander Shishkin
2019-09-26 12:04 ` Alexander Shishkin
2019-09-26 14:44 ` Peter Zijlstra
2019-09-30 11:50 ` Alexander Shishkin
2018-06-12 7:51 ` [PATCH v1 5/6] perf: Drop PERF_FLAG_FD_OUTPUT Alexander Shishkin
2018-06-12 7:51 ` [PATCH v1 6/6] perf: Allow set-output for task contexts of different types Alexander Shishkin
2018-06-14 19:36 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180612075117.65420-3-alexander.shishkin@linux.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox