From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id EEC20C433EF for ; Wed, 13 Jun 2018 04:49:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A44A9208AF for ; Wed, 13 Jun 2018 04:49:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zKyDmhEd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A44A9208AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754486AbeFMEtE (ORCPT ); Wed, 13 Jun 2018 00:49:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:41132 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754325AbeFMEtD (ORCPT ); Wed, 13 Jun 2018 00:49:03 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8179220693; Wed, 13 Jun 2018 04:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1528865342; bh=thlu0s6GTJT0ww6IBHq0it5MbuMKJJwN++4QcYNkUXE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zKyDmhEdp1Y3fjc3LD70HPwWxyhBXu1/DHjzEALn4rCsFo3uy0AhDtMqsAN0amUJ6 7NlLbhW0w8plgoMWwLE6dogDSRxq3ljpyDcCCcvq2JrdqHu72P+UN+NBt/GG3AQNTd re5V3JnEPgu9UUgHvvlweYf1yvYsr3/GWryOW2Jg= Date: Wed, 13 Jun 2018 06:48:40 +0200 From: Greg Kroah-Hartman To: Linus Torvalds Cc: Wanpeng Li , Thomas-Mich Richter , Kees Cook , Paolo Bonzini , Linux Kernel Mailing List , Radim =?utf-8?B?S3LEjW3DocWZ?= , KVM list Subject: Re: [GIT PULL] KVM changes for 4.18 merge window Message-ID: <20180613044840.GA669@kroah.com> References: <1528812229-53043-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 12, 2018 at 08:52:08PM -0700, Linus Torvalds wrote: > On Tue, Jun 12, 2018 at 8:26 PM Linus Torvalds > wrote: > > > > Ok, so commit 95cde3c59966 ("debugfs: inode: debugfs_create_dir uses > > mode permission from parent") breaks lkvm, and I think qemu-kvm too. > > > > The commit looks like the RightThing(tm) to do, but we do not break > > existing work-flows, no matter how much we'd like to. So it gets > > reverted. > > I suspect it's the special kvm debugfs entries - see kvm_create_vm_debugfs() > > Anyway, I've verified that both qemu-kvm and kvm-tool work fine with > the revert in place. I should have read the whole thread :) The revert is fine, I'll work on the kvm debugfs file stuff for 4.19. thanks, greg k-h