From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id A09C1C004E4 for ; Wed, 13 Jun 2018 07:23:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5719F2086A for ; Wed, 13 Jun 2018 07:23:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="ZUilLF8C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5719F2086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934754AbeFMHXI (ORCPT ); Wed, 13 Jun 2018 03:23:08 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60321 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934150AbeFMHXG (ORCPT ); Wed, 13 Jun 2018 03:23:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=fyfJCRhZ2ft+ylu9AHXd2vApAWoAmi/3yo7VcAyUokM=; b=ZUilLF8Cc6Kngg12PfjY86zrWD9Mb13H124g5ilMELFfv5DjrQn9j0Sl6MT3dFO5DTUt+HWPD5F5k7QoLHbaIBn2XnqaQy2tWcUC+NaH31AxzaCkzhC/cdYH1YFfrE0RvZVHa6hgDCqx/XGZHqqRMh+0L3XyfTxZym6gEPiz7mw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1fT07R-0006gF-GG; Wed, 13 Jun 2018 09:23:01 +0200 Date: Wed, 13 Jun 2018 09:23:01 +0200 From: Andrew Lunn To: Radhey Shyam Pandey Cc: davem@davemloft.net, michal.simek@xilinx.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] net: emaclite: Fix MDIO bus unregister bug Message-ID: <20180613072301.GC24314@lunn.ch> References: <1528871719-1681-1-git-send-email-radhey.shyam.pandey@xilinx.com> <1528871719-1681-3-git-send-email-radhey.shyam.pandey@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1528871719-1681-3-git-send-email-radhey.shyam.pandey@xilinx.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 13, 2018 at 12:05:17PM +0530, Radhey Shyam Pandey wrote: > Since 'has_mdio' flag is not used,sequence insmod->rmmod-> insmod > leads to failure as MDIO unregister doesn't happen in .remove(). > Fix it by checking MII bus pointer instead. > > Signed-off-by: Radhey Shyam Pandey > Signed-off-by: Michal Simek Reviewed-by: Andrew Lunn Andrew