From: Hugo Lefeuvre <hle@owl.eu.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Marcus Wolf <linux@wolf-entwicklungen.de>,
linux-kernel@vger.kernel.org, kernelnewbies@kernelnewbies.org
Subject: Re: [PATCH v2] staging: pi433: fix race condition in pi433_ioctl
Date: Wed, 13 Jun 2018 21:10:37 -0400 [thread overview]
Message-ID: <20180614011037.GA21075@hle-laptop.local> (raw)
In-Reply-To: <20180613091649.r3bck3wjma6tmjet@mwanda>
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
Hi Dan,
> There is no need for this comment, since it's obvious. Also if you use
> simpler names then the copy fits on one line:
>
> if (copy_from_user(&tx_cfg, argp, sizeof(tx_cfg)) {
>
>
> > + mutex_lock(&device->tx_fifo_lock);
> > + if (copy_from_user(&tx_cfg_buffer, argp,
> > + sizeof(struct pi433_tx_cfg))) {
>
> Sorry for the duplicate review, but it got sent to both my inboxes... :P
Thanks for your review ! Patch updated.
Please tell me if you don't to be CC-ed anymore. :)
regards,
Hugo
--
Hugo Lefeuvre (hle) | www.owl.eu.com
4096/ 9C4F C8BF A4B0 8FC5 48EB 56B8 1962 765B B9A8 BACA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2018-06-14 1:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 1:47 [PATCH v2] staging: pi433: fix race condition in pi433_ioctl Hugo Lefeuvre
2018-06-13 9:08 ` Dan Carpenter
2018-06-13 9:16 ` Dan Carpenter
2018-06-14 1:10 ` Hugo Lefeuvre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614011037.GA21075@hle-laptop.local \
--to=hle@owl.eu.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernelnewbies@kernelnewbies.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@wolf-entwicklungen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox