public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Parth Y Shah <sparth1292@gmail.com>
Cc: balbi@kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Fixed a checkpatch error
Date: Thu, 14 Jun 2018 08:42:29 +0200	[thread overview]
Message-ID: <20180614064229.GA12429@kroah.com> (raw)
In-Reply-To: <1528957966-24707-1-git-send-email-sparth1292@gmail.com>

On Thu, Jun 14, 2018 at 12:02:46PM +0530, Parth Y Shah wrote:
> ERROR: code indent should use tabs where possible
> 
> Here, spaces are replaced by a tab in 2 lines.
> 
> Signed-off-by: Parth Y Shah <sparth1292@gmail.com>

Your subject line needs work, please see how other subject lines are
composed for this subsystem.

Also note, please do not use anything but the drivers/staging/ area of
the kernel for beginning "I'm going to do checkpatch cleanups" type of
"learning to get changes into the kernel" work.  That is a great place
to start with this, not in other subsystems where you might have
reviewers who do not care so much about whitespace cleanups like this.

So please learn the process there, and when you have it all working
well, then you could move on to other subsystems and areas of the
kernel, like this one, if you want to.

thanks,

greg k-h

  reply	other threads:[~2018-06-14  6:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13 12:25 [PATCH] Fixed an indentation error Parth Y Shah
2018-06-13 12:32 ` Joe Perches
2018-06-14  6:32   ` [PATCH v2] Fixed a checkpatch error Parth Y Shah
2018-06-14  6:42     ` Greg KH [this message]
2018-06-13 12:36 ` [PATCH] Fixed an indentation error Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180614064229.GA12429@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=balbi@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sparth1292@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox