From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id 37BB3C433EF for ; Thu, 14 Jun 2018 07:28:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC78D208CB for ; Thu, 14 Jun 2018 07:28:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC78D208CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754694AbeFNH2v (ORCPT ); Thu, 14 Jun 2018 03:28:51 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:40040 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752781AbeFNH2t (ORCPT ); Thu, 14 Jun 2018 03:28:49 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 76A2B87AC7; Thu, 14 Jun 2018 07:28:48 +0000 (UTC) Received: from ming.t460p (ovpn-12-72.pek2.redhat.com [10.72.12.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DDFAD111D3CB; Thu, 14 Jun 2018 07:28:33 +0000 (UTC) Date: Thu, 14 Jun 2018 15:28:29 +0800 From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , Alexander Viro , Kent Overstreet , David Sterba , Huang Ying , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , "Darrick J . Wong" , Coly Li , Filipe Manana , Randy Dunlap Subject: Re: [PATCH V6 15/30] block: introduce bio_clone_chunk_bioset() Message-ID: <20180614072828.GA26621@ming.t460p> References: <20180609123014.8861-1-ming.lei@redhat.com> <20180609123014.8861-16-ming.lei@redhat.com> <20180613145654.GE4693@infradead.org> <20180614020137.GF19828@ming.t460p> <20180614063920.GA10284@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180614063920.GA10284@infradead.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 14 Jun 2018 07:28:48 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 14 Jun 2018 07:28:48 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'ming.lei@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 13, 2018 at 11:39:20PM -0700, Christoph Hellwig wrote: > On Thu, Jun 14, 2018 at 10:01:38AM +0800, Ming Lei wrote: > > Bounce limits the max pages as 256 will do bio splitting, so won't need > > this change. > > Behavior for the bounce code does not change with my patch. > > The important points are: > > - the default interface (bio_clone_bioset in this case) should always > operate on full biosets > - if the bounce code needs bioves limited to single pages it should > be treated as the special case > - given that the bounce code is inside the block layer using the > __-prefixed internal interface is perfectly fine > - last but not least I think the parameter switching the behavior > needs a much more descriptive name as suggested in my patch Fair enough, will switch to this way and avoid DM's change, even though it is a dying interface. Thanks, Ming