From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id 0F767C07D5C for ; Thu, 14 Jun 2018 12:38:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5DE5208D8 for ; Thu, 14 Jun 2018 12:38:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5DE5208D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936046AbeFNMiT (ORCPT ); Thu, 14 Jun 2018 08:38:19 -0400 Received: from muru.com ([72.249.23.125]:47162 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964796AbeFNMiL (ORCPT ); Thu, 14 Jun 2018 08:38:11 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id C26A180AE; Thu, 14 Jun 2018 12:40:45 +0000 (UTC) Date: Thu, 14 Jun 2018 05:38:05 -0700 From: Tony Lindgren To: Nishanth Menon Cc: Rob Herring , Santosh Shilimkar , Will Deacon , Catalin Marinas , Greg Kroah-Hartman , Mark Rutland , "open list:SERIAL DRIVERS" , "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Vignesh R , Tero Kristo , Russell King , Sudeep Holla Subject: Re: [RFC PATCH 5/6] arm64: dts: ti: Add Support for AM654 SoC Message-ID: <20180614123805.GF112168@atomide.com> References: <20180605060510.32473-1-nm@ti.com> <20180607233853.p7iw7nlxxuyi66og@kahuna> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180607233853.p7iw7nlxxuyi66og@kahuna> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Some comments on the ranges below. * Nishanth Menon [180607 16:41]: > + soc0: soc0 { > + compatible = "simple-bus"; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; I suggest you leave out the soc0, that's not real. Just make the cbass@0 the top level interconnect. It can then provide ranges to mcu interconnect which can provide ranges to the wkup interconnect. So just model it after what's in the hardware :) I found the following ranges based on a quick look at the TRM, they could be split further if needed for power domains for genpd for example. main covers 0x0000000000 - 0x5402000000 main provides at least the following ranges for mcu 0x0028380000 - 0x002bc00000 0x0040080000 - 0x0041c80000 0x0045100000 - 0x0045180000 0x0045600000 - 0x0045640000 0x0045810000 - 0x0045860000 0x0045950000 - 0x0045950400 0x0045a50000 - 0x0045a50400 0x0045b04000 - 0x0045b06400 0x0045d10000 - 0x0045d24000 0x0046000000 - 0x0060000000 0x0400000000 - 0x0800000000 0x4c3c020000 - 0x4c3c030000 0x4c3e000000 - 0x4c3e040000 0x5400000000 - 0x5402000000 then mcu provides the following ranges for wkup 0x0042000000 - 0x0044410020 0x0045000000 - 0x0045030000 0x0045080000 - 0x00450a0000 0x0045808000 - 0x0045808800 0x0045b00000 - 0x0045b02400 This based on looking at "figure 1-1. device top-level block diagram" and the memory map in TRM. Regards, Tony