From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: ** X-Spam-Status: No, score=2.2 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,T_DKIM_INVALID, UNWANTED_LANGUAGE_BODY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id 4BB05C07D5C for ; Thu, 14 Jun 2018 19:25:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC762208D4 for ; Thu, 14 Jun 2018 19:25:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="rGr6mKWB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC762208D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754874AbeFNTZQ (ORCPT ); Thu, 14 Jun 2018 15:25:16 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:60110 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754660AbeFNTZP (ORCPT ); Thu, 14 Jun 2018 15:25:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=p2anNKIpXzZVDKMbyQRbyfypqFSJr0HM9zqjuxVcmiQ=; b=rGr6mKWBD8K6a+NnzvrbnIp0K 1zDIOyEiEiqeDrBCgu9E8IYCl5cuSXSFzw8yyW93jNEYDKaorVcS1HEtR9EqmHbhnoyJeT/plKTQI 39BnWj32vWezGP+TGiKOHO82KQn5lnwbcoBcOHKAsDQ+YZmUEcCYVZylRjCdvxUAkr3juLri8+GlA Pfz1Zao03DSvKklSRbkvQuDMb1pl30wJ99X78mivga4b98USnbUA3jpeB/acSQk3YHSzio3ZjQlHX MLxqXEbJMPm89luv/0y92tb7yOMLBPnOfWwS5MIqMThgGE2tpgBSLMKOth8UQinGbEFlqjppPyO8G JdkpqJq8A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fTXru-0007Ta-M4; Thu, 14 Jun 2018 19:25:14 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 14CBC201EA7C8; Thu, 14 Jun 2018 21:25:13 +0200 (CEST) Date: Thu, 14 Jun 2018 21:25:13 +0200 From: Peter Zijlstra To: Alexander Shishkin Cc: Ingo Molnar , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, jolsa@redhat.com Subject: Re: [PATCH v1 4/6] perf: Allow using AUX data in perf samples Message-ID: <20180614192513.GX12217@hirez.programming.kicks-ass.net> References: <20180612075117.65420-1-alexander.shishkin@linux.intel.com> <20180612075117.65420-5-alexander.shishkin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180612075117.65420-5-alexander.shishkin@linux.intel.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 12, 2018 at 10:51:15AM +0300, Alexander Shishkin wrote: > @@ -882,6 +890,7 @@ struct perf_sample_data { > */ > u64 addr; > struct perf_raw_record *raw; > + struct perf_aux_record aux; > struct perf_branch_stack *br_stack; > u64 period; > u64 weight; > @@ -933,6 +942,7 @@ static inline void perf_sample_data_init(struct perf_sample_data *data, > /* remaining struct members initialized in perf_prepare_sample() */ > data->addr = addr; > data->raw = NULL; > + data->aux.from = data->aux.to = data->aux.size = 0; > data->br_stack = NULL; > data->period = period; > data->weight = 0; You just blew that cacheline...