From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id C8476C5CFC1 for ; Fri, 15 Jun 2018 04:56:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71C52208D7 for ; Fri, 15 Jun 2018 04:56:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PocKCwIe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71C52208D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755571AbeFOE4a (ORCPT ); Fri, 15 Jun 2018 00:56:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:36500 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754165AbeFOE43 (ORCPT ); Fri, 15 Jun 2018 00:56:29 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8BE5C2086A; Fri, 15 Jun 2018 04:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1529038588; bh=HjsIwJz8BHrjqM6exA6JhpGE/dFSa/omYzpXBg7JsSE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PocKCwIew9k/c+iAZXuX53Rq6nPlRWMs/MMskGr46d7tpA9NrNaGz99Fx+EX10Z6q bK425dzJiLOlP8prUFZnWChe8ZVQ9atFnpXse93eCdmf4JNN2QBJ39HsDwH8SbTkgl 2NlUeIPM8RPW5rHCUFiqI5/FzZi/+zKllnBNVLgs= Date: Fri, 15 Jun 2018 06:56:04 +0200 From: 'Greg Kroah-Hartman' To: Daniel Sangorrin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, 'Andy Lutomirski' , 'Rik van Riel' , 'Borislav Petkov' , 'Brian Gerst' , 'Dave Hansen' , 'Denys Vlasenko' , 'Fenghua Yu' , "'H. Peter Anvin'" , 'Josh Poimboeuf' , 'Linus Torvalds' , 'Oleg Nesterov' , 'Peter Zijlstra' , 'Quentin Casasnovas' , 'Thomas Gleixner' , pbonzini@redhat.com, 'Ingo Molnar' Subject: Re: [PATCH 4.4 10/24] x86/fpu: Hard-disable lazy FPU mode Message-ID: <20180615045604.GA8664@kroah.com> References: <20180614132724.483802160@linuxfoundation.org> <20180614132724.905032027@linuxfoundation.org> <000c01d40460$bfc97710$3f5c6530$@toshiba.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000c01d40460$bfc97710$3f5c6530$@toshiba.co.jp> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 15, 2018 at 01:24:27PM +0900, Daniel Sangorrin wrote: > Hi Greg, > > > /* Intel-defined CPU features, CPUID level 0x00000001 (ecx), word 4 */ > > --- a/arch/x86/include/asm/fpu/internal.h > > +++ b/arch/x86/include/asm/fpu/internal.h > > @@ -58,7 +58,7 @@ extern u64 fpu__get_supported_xfeatures_ > > */ > > static __always_inline __pure bool use_eager_fpu(void) > > { > > - return static_cpu_has_safe(X86_FEATURE_EAGER_FPU); > > + return true; > > } > > Since this function returns always true then we can remove the code depending on lazy FPU mode. > Actually this has already been done in "x86/fpu: Remove use_eager_fpu()" > Ref: https://patchwork.kernel.org/patch/9365883/ > > > static void __init fpu__init_parse_early_param(void) > > { > > - if (cmdline_find_option_bool(boot_command_line, "eagerfpu=off")) { > > - eagerfpu = DISABLE; > > - fpu__clear_eager_fpu_features(); > > - } > > Since this patch removes the kernel boot parameter "eagerfpu", maybe we should remove it from the Documentation. > This has also been done by commit "x86/fpu: Finish excising 'eagerfpu'" > Ref: https://patchwork.kernel.org/patch/9380673/ > > I will try backporting those patches unless anyone has any objections. What are the git commit ids of those patches in Linus's tree? No need to point to patchwork links, I don't use that tool. thanks, greg k-h