* [PATCH] drm/nouveau/nvif: remove const attribute from nvif_mclass
@ 2018-06-15 22:56 Nick Desaulniers
2018-06-15 22:58 ` Nick Desaulniers
0 siblings, 1 reply; 4+ messages in thread
From: Nick Desaulniers @ 2018-06-15 22:56 UTC (permalink / raw)
To: bskeggs, airlied
Cc: mka, jeyu, Nick Desaulniers, Philippe Ombredanne, Thomas Gleixner,
Greg Kroah-Hartman, dri-devel, nouveau, linux-kernel
Similar to commit 0bf8bf50eddc ("module: Remove
const attribute from alias for MODULE_DEVICE_TABLE")
Fixes many -Wduplicate-decl-specifier warnings due to the combination of
const typeof() of already const variables.
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
drivers/gpu/drm/nouveau/include/nvif/object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/include/nvif/object.h b/drivers/gpu/drm/nouveau/include/nvif/object.h
index a2d5244ff2b7..7f188f66931e 100644
--- a/drivers/gpu/drm/nouveau/include/nvif/object.h
+++ b/drivers/gpu/drm/nouveau/include/nvif/object.h
@@ -78,7 +78,7 @@ struct nvif_mclass {
#define nvif_mclass(o,m) ({ \
struct nvif_object *object = (o); \
struct nvif_sclass *sclass; \
- const typeof(m[0]) *mclass = (m); \
+ typeof(m[0]) *mclass = (m); \
int ret = -ENODEV; \
int cnt, i, j; \
\
--
2.18.0.rc1.244.gcf134e6275-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/nouveau/nvif: remove const attribute from nvif_mclass
2018-06-15 22:56 [PATCH] drm/nouveau/nvif: remove const attribute from nvif_mclass Nick Desaulniers
@ 2018-06-15 22:58 ` Nick Desaulniers
2018-06-15 23:00 ` [PATCH v2] " Nick Desaulniers
0 siblings, 1 reply; 4+ messages in thread
From: Nick Desaulniers @ 2018-06-15 22:58 UTC (permalink / raw)
To: bskeggs, airlied
Cc: Matthias Kaehlcke, Jessica Yu, Philippe Ombredanne,
Thomas Gleixner, Greg KH, dri-devel, nouveau, LKML
On Fri, Jun 15, 2018 at 3:56 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> Similar to commit 0bf8bf50eddc ("module: Remove
> const attribute from alias for MODULE_DEVICE_TABLE")
>
> Fixes many -Wduplicate-decl-specifier warnings due to the combination of
> const typeof() of already const variables.
>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> drivers/gpu/drm/nouveau/include/nvif/object.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/include/nvif/object.h b/drivers/gpu/drm/nouveau/include/nvif/object.h
> index a2d5244ff2b7..7f188f66931e 100644
> --- a/drivers/gpu/drm/nouveau/include/nvif/object.h
> +++ b/drivers/gpu/drm/nouveau/include/nvif/object.h
> @@ -78,7 +78,7 @@ struct nvif_mclass {
> #define nvif_mclass(o,m) ({ \
> struct nvif_object *object = (o); \
> struct nvif_sclass *sclass; \
> - const typeof(m[0]) *mclass = (m); \
> + typeof(m[0]) *mclass = (m); \
Sorry, this messes up the spaces at the end, will send a v2.
> int ret = -ENODEV; \
> int cnt, i, j; \
> \
> --
> 2.18.0.rc1.244.gcf134e6275-goog
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] drm/nouveau/nvif: remove const attribute from nvif_mclass
2018-06-15 22:58 ` Nick Desaulniers
@ 2018-06-15 23:00 ` Nick Desaulniers
2018-06-16 0:47 ` Matthias Kaehlcke
0 siblings, 1 reply; 4+ messages in thread
From: Nick Desaulniers @ 2018-06-15 23:00 UTC (permalink / raw)
To: bskeggs, airlied
Cc: mka, jeyu, Nick Desaulniers, Thomas Gleixner, Philippe Ombredanne,
Greg Kroah-Hartman, Kate Stewart, dri-devel, nouveau,
linux-kernel
Similar to commit 0bf8bf50eddc ("module: Remove
const attribute from alias for MODULE_DEVICE_TABLE")
Fixes many -Wduplicate-decl-specifier warnings due to the combination of
const typeof() of already const variables.
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
Changes since v1: added additional space after statements.
drivers/gpu/drm/nouveau/include/nvif/object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/include/nvif/object.h b/drivers/gpu/drm/nouveau/include/nvif/object.h
index a2d5244ff2b7..3d7e485a9043 100644
--- a/drivers/gpu/drm/nouveau/include/nvif/object.h
+++ b/drivers/gpu/drm/nouveau/include/nvif/object.h
@@ -78,7 +78,7 @@ struct nvif_mclass {
#define nvif_mclass(o,m) ({ \
struct nvif_object *object = (o); \
struct nvif_sclass *sclass; \
- const typeof(m[0]) *mclass = (m); \
+ typeof(m[0]) *mclass = (m); \
int ret = -ENODEV; \
int cnt, i, j; \
\
--
2.18.0.rc1.244.gcf134e6275-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] drm/nouveau/nvif: remove const attribute from nvif_mclass
2018-06-15 23:00 ` [PATCH v2] " Nick Desaulniers
@ 2018-06-16 0:47 ` Matthias Kaehlcke
0 siblings, 0 replies; 4+ messages in thread
From: Matthias Kaehlcke @ 2018-06-16 0:47 UTC (permalink / raw)
To: Nick Desaulniers
Cc: bskeggs, airlied, jeyu, Thomas Gleixner, Philippe Ombredanne,
Greg Kroah-Hartman, Kate Stewart, dri-devel, nouveau,
linux-kernel
On Fri, Jun 15, 2018 at 04:00:42PM -0700, Nick Desaulniers wrote:
> Similar to commit 0bf8bf50eddc ("module: Remove
> const attribute from alias for MODULE_DEVICE_TABLE")
>
> Fixes many -Wduplicate-decl-specifier warnings due to the combination of
> const typeof() of already const variables.
>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-16 0:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-15 22:56 [PATCH] drm/nouveau/nvif: remove const attribute from nvif_mclass Nick Desaulniers
2018-06-15 22:58 ` Nick Desaulniers
2018-06-15 23:00 ` [PATCH v2] " Nick Desaulniers
2018-06-16 0:47 ` Matthias Kaehlcke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox