From: Greg KH <gregkh@linuxfoundation.org>
To: Jay Buddhabhatti <jay.buddhabhatti@softnautics.com>
Cc: thomas.petazzoni@free-electrons.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: Add missing blank line after function definition
Date: Mon, 18 Jun 2018 13:45:29 +0200 [thread overview]
Message-ID: <20180618114529.GA6421@kroah.com> (raw)
In-Reply-To: <1529321261-7727-1-git-send-email-jay.buddhabhatti@softnautics.com>
On Mon, Jun 18, 2018 at 04:57:41PM +0530, Jay Buddhabhatti wrote:
> Reslove checkpatch warnings by adding missing blank line after
> function definition.
>
> Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@softnautics.com>
> ---
> drivers/staging/fbtft/fb_s6d1121.c | 1 +
> drivers/staging/fbtft/fb_ssd1289.c | 1 +
> drivers/staging/fbtft/fb_st7735r.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/drivers/staging/fbtft/fb_s6d1121.c b/drivers/staging/fbtft/fb_s6d1121.c
> index b902442..b0c7a77 100644
> --- a/drivers/staging/fbtft/fb_s6d1121.c
> +++ b/drivers/staging/fbtft/fb_s6d1121.c
> @@ -154,6 +154,7 @@ static int set_gamma(struct fbtft_par *par, u32 *curves)
>
> return 0;
> }
> +
> #undef CURVE
>
> static struct fbtft_display display = {
There already is a blank line here, no need to add another one. Looks
like checkpatch.pl is being a bit too over-eager here, sorry.
thanks,
greg k-h
prev parent reply other threads:[~2018-06-18 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 11:27 [PATCH] staging: fbtft: Add missing blank line after function definition Jay Buddhabhatti
2018-06-18 11:45 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618114529.GA6421@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=jay.buddhabhatti@softnautics.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox