* [PATCH] staging: fbtft: Add missing blank line after function definition
@ 2018-06-18 11:27 Jay Buddhabhatti
2018-06-18 11:45 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jay Buddhabhatti @ 2018-06-18 11:27 UTC (permalink / raw)
To: thomas.petazzoni, gregkh, devel; +Cc: linux-kernel, Jay Buddhabhatti
Reslove checkpatch warnings by adding missing blank line after
function definition.
Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@softnautics.com>
---
drivers/staging/fbtft/fb_s6d1121.c | 1 +
drivers/staging/fbtft/fb_ssd1289.c | 1 +
drivers/staging/fbtft/fb_st7735r.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/drivers/staging/fbtft/fb_s6d1121.c b/drivers/staging/fbtft/fb_s6d1121.c
index b902442..b0c7a77 100644
--- a/drivers/staging/fbtft/fb_s6d1121.c
+++ b/drivers/staging/fbtft/fb_s6d1121.c
@@ -154,6 +154,7 @@ static int set_gamma(struct fbtft_par *par, u32 *curves)
return 0;
}
+
#undef CURVE
static struct fbtft_display display = {
diff --git a/drivers/staging/fbtft/fb_ssd1289.c b/drivers/staging/fbtft/fb_ssd1289.c
index cbf22e1..b35d5b2 100644
--- a/drivers/staging/fbtft/fb_ssd1289.c
+++ b/drivers/staging/fbtft/fb_ssd1289.c
@@ -153,6 +153,7 @@ static int set_gamma(struct fbtft_par *par, u32 *curves)
return 0;
}
+
#undef CURVE
static struct fbtft_display display = {
diff --git a/drivers/staging/fbtft/fb_st7735r.c b/drivers/staging/fbtft/fb_st7735r.c
index 631208b..c2089f4 100644
--- a/drivers/staging/fbtft/fb_st7735r.c
+++ b/drivers/staging/fbtft/fb_st7735r.c
@@ -152,6 +152,7 @@ static int set_gamma(struct fbtft_par *par, u32 *curves)
return 0;
}
+
#undef CURVE
static struct fbtft_display display = {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: fbtft: Add missing blank line after function definition
2018-06-18 11:27 [PATCH] staging: fbtft: Add missing blank line after function definition Jay Buddhabhatti
@ 2018-06-18 11:45 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2018-06-18 11:45 UTC (permalink / raw)
To: Jay Buddhabhatti; +Cc: thomas.petazzoni, devel, linux-kernel
On Mon, Jun 18, 2018 at 04:57:41PM +0530, Jay Buddhabhatti wrote:
> Reslove checkpatch warnings by adding missing blank line after
> function definition.
>
> Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@softnautics.com>
> ---
> drivers/staging/fbtft/fb_s6d1121.c | 1 +
> drivers/staging/fbtft/fb_ssd1289.c | 1 +
> drivers/staging/fbtft/fb_st7735r.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/drivers/staging/fbtft/fb_s6d1121.c b/drivers/staging/fbtft/fb_s6d1121.c
> index b902442..b0c7a77 100644
> --- a/drivers/staging/fbtft/fb_s6d1121.c
> +++ b/drivers/staging/fbtft/fb_s6d1121.c
> @@ -154,6 +154,7 @@ static int set_gamma(struct fbtft_par *par, u32 *curves)
>
> return 0;
> }
> +
> #undef CURVE
>
> static struct fbtft_display display = {
There already is a blank line here, no need to add another one. Looks
like checkpatch.pl is being a bit too over-eager here, sorry.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-18 11:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-18 11:27 [PATCH] staging: fbtft: Add missing blank line after function definition Jay Buddhabhatti
2018-06-18 11:45 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox