From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC220C433EF for ; Mon, 18 Jun 2018 16:37:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8067520020 for ; Mon, 18 Jun 2018 16:37:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8067520020 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935157AbeFRQhe (ORCPT ); Mon, 18 Jun 2018 12:37:34 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:38018 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934644AbeFRQhb (ORCPT ); Mon, 18 Jun 2018 12:37:31 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3D63C1529; Mon, 18 Jun 2018 09:37:31 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0D77E3F25D; Mon, 18 Jun 2018 09:37:31 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 6B5291AE10A0; Mon, 18 Jun 2018 17:38:06 +0100 (BST) Date: Mon, 18 Jun 2018 17:38:06 +0100 From: Will Deacon To: Mark Rutland Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, boqun.feng@gmail.com, mingo@kernel.org, albert@sifive.com, arnd@arndb.de, benh@kernel.crashing.org, geert@linux-m68k.org, ink@jurassic.park.msu.ru, linux@armlinux.org.uk, mattst88@gmail.com, mpe@ellerman.id.au, palmer@sifive.com, paulus@samba.org, rth@twiddle.net, vgupta@synopsys.com Subject: Re: [PATCHv3 00/18] atomics: API cleanups Message-ID: <20180618163805.GE11612@arm.com> References: <20180618101919.51973-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180618101919.51973-1-mark.rutland@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 18, 2018 at 11:19:01AM +0100, Mark Rutland wrote: > This series contains a few cleanups of the atomic API, fixing > inconsistencies between atomic_* and atomic64_*, and minimizing > repetition in arch code. This is nicer for arch code, and the improved > regularity will help when generating the atomic headers in future. Apart from the Alpha patch: Reviewed-by: Will Deacon I also tried to compare disassembly before/after, but the changes to add_unless made that quite fiddly for anything using it as a backend. Do you plan to move arm64 over to atomic-instrumented.h at some point? Will