From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98B63C5AE59 for ; Mon, 18 Jun 2018 17:20:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 591C3208CA for ; Mon, 18 Jun 2018 17:20:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 591C3208CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935397AbeFRRUz (ORCPT ); Mon, 18 Jun 2018 13:20:55 -0400 Received: from mail.skyhub.de ([5.9.137.197]:37000 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934215AbeFRRUx (ORCPT ); Mon, 18 Jun 2018 13:20:53 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id z1KBc7eWXqZ5; Mon, 18 Jun 2018 19:20:51 +0200 (CEST) Received: from zn.tnic (p200300EC2BE29C00329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2be2:9c00:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B6E701EC0299; Mon, 18 Jun 2018 19:20:51 +0200 (CEST) Date: Mon, 18 Jun 2018 19:20:48 +0200 From: Borislav Petkov To: Suravee Suthikulpanit Cc: x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com Subject: Re: [PATCH] x86/CPU/AMD: Fix LLC ID bit-shift calculation Message-ID: <20180618172048.GD24921@zn.tnic> References: <1528915390-30533-1-git-send-email-suravee.suthikulpanit@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1528915390-30533-1-git-send-email-suravee.suthikulpanit@amd.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 13, 2018 at 01:43:10PM -0500, Suravee Suthikulpanit wrote: > The current logic incorrectly calculates the LLC ID from the APIC ID. > Unless specified otherwise, the LLC ID should be calculated from > the count order of the number of threads sharing cache. Don't you mean: "... should be calculated by removing the Core and Thread ID bits"? here? I'm looking at "2.1.10.2.1.3 ApicId Enumeration Requirements ... Each Core::X86::Apic::ApicId[ApicId] register is preset as follows: • ApicId[6] = Socket ID. • ApicId[5:4] = Node ID. • ApicId[3] = Logical CCX L3 complex ID • ApicId[2:0]= (SMT) ? {LogicalCoreID[1:0],ThreadId} : {1'b0,LogicalCoreID[1:0]}. and in order to get a unique LLC ID, you simply need to shift out the CoreID and the ThreadId, right? Or am I misreading it? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.