From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D5F9C5AE59 for ; Mon, 18 Jun 2018 20:11:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 168C920693 for ; Mon, 18 Jun 2018 20:11:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="b7ZHrgAi"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="CVLKiXtu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 168C920693 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935350AbeFRULf (ORCPT ); Mon, 18 Jun 2018 16:11:35 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35590 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933073AbeFRULe (ORCPT ); Mon, 18 Jun 2018 16:11:34 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 84A4A60B10; Mon, 18 Jun 2018 20:11:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1529352693; bh=akGvf5aGxs/wkPg1NIm+1L4GeMoSDtAKIQAWSr3jCr0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b7ZHrgAioCFolo8MnwI6/M7WxFNY8uBurHcALjxztkJIkKIekkuVkxN10tt7pQda4 V5eh9KnrYEsJRc1n139ZFq7isjeE2DG//6r76qdygGIPfCzxHdMsLVQcyacChFw2yQ 3Sqdgjt6Pq9nw7Yp5gicyB2XCtwME/3Va4CKsBmk= Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: ilina@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id AF62460AD9; Mon, 18 Jun 2018 20:11:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1529352692; bh=akGvf5aGxs/wkPg1NIm+1L4GeMoSDtAKIQAWSr3jCr0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CVLKiXtunbzlq9LM+8NX2CP7wTEeRS+Ug3amIYXMu0CQtza2N3A6onF62Cx8xBOJ6 XjkdC8bGvCLPosdAZYMiEmeXaJA57z1RbnLTaclB/19jl0k5XLhzpsBfqPzXGLC6eG R8yObaakCZdXSp8Qpg4GV/PbrKfX02F8sFLkA8vE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AF62460AD9 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=ilina@codeaurora.org Date: Mon, 18 Jun 2018 14:11:29 -0600 From: Lina Iyer To: Doug Anderson Cc: Raju P L S S S N , Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, "open list:ARM/QUALCOMM SUPPORT" , Rajendra Nayak , Bjorn Andersson , LKML , Stephen Boyd , Evan Green , Matthias Kaehlcke Subject: Re: [PATCH v11 04/10] drivers: qcom: rpmh: add RPMH helper functions Message-ID: <20180618201129.GH21724@codeaurora.org> References: <1529329040-2606-1-git-send-email-rplsssn@codeaurora.org> <1529329040-2606-5-git-send-email-rplsssn@codeaurora.org> <20180618163945.GE21724@codeaurora.org> <20180618190637.GG21724@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 18 2018 at 13:54 -0600, Doug Anderson wrote: >Hi, > >On Mon, Jun 18, 2018 at 12:06 PM, Lina Iyer wrote: >> On Mon, Jun 18 2018 at 12:33 -0600, Doug Anderson wrote: >>> >>> Lina, >>> >>> On Mon, Jun 18, 2018 at 9:39 AM, Lina Iyer wrote: >>>>> >>>>> +/** >>>>> * struct rsc_drv: the Direct Resource Voter (DRV) of the >>>>> * Resource State Coordinator controller (RSC) >>>>> * >>>>> @@ -52,6 +78,7 @@ struct tcs_group { >>>>> * @tcs: TCS groups >>>>> * @tcs_in_use: s/w state of the TCS >>>>> * @lock: synchronize state of the controller >>>>> + * @ctrl: controller to handle cases like batch requests >>>> >>>> >>>> This is not only for batch requests. >>>> This is handle to the DRV's client. @client might be a better name than >>>> @ctrlr. >>> >>> >>> The name "ctrlr" also matches the name of the structure. Are you >>> suggesting also renaming "struct rpmh_ctrlr" to "struct rpmh_client", >>> or you think they should be different names? >>> >> Just the name of the variable. I was just a nice to have. I wouldn't >> block for this though. >> >> I also got a couple Bot reported issues on this and the previous >> revision that I have sent to Raju. He is planning to the post the v12 >> tomorrow his time after fixing them. If you can wait until then, I would >> recommend picking up the v12 instead of this. > >OK, if Raju can post the v12 tomorrow his time then that sounds like a >great plan to me. While you're at it, I noticed that checkpatch >yelled about a few lines that were > 80 characters long for no good >reason. Those would be nice to fix too. > Yup. He got that too. -- Lina