Re: [PATCH v2] firmware: Update Kconfig help text for Google firmware

Salvatore Bonaccorso
2021-12-19T13:08:56Z

Hi,

On Mon, Jun 18, 2018 at 11:55:40PM +0100, Ben Hutchings wrote:
> The help text for GOOGLE_FIRMWARE states that it should only be
> enabled when building a kernel for Google's own servers. However,
> many of the drivers dependent on it are also useful on Chromebooks or
> on any platform using coreboot.
>
> Update the help text to reflect this double duty.
>
> Fixes: d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> v2: Mention coreboot, and don't touch GSMI help text
>
> drivers/firmware/google/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
> index f16b381a569c..ca049ecf5cfd 100644
> --- a/drivers/firmware/google/Kconfig
> +++ b/drivers/firmware/google/Kconfig
> @@ -2,9 +2,9 @@ menuconfig GOOGLE_FIRMWARE
> bool "Google Firmware Drivers"
> default n
> help
> - These firmware drivers are used by Google's servers. They are
> - only useful if you are working directly on one of their
> - proprietary servers. If in doubt, say "N".
> + These firmware drivers are used by Google servers,
> + Chromebooks and other devices using coreboot firmware.
> + If in doubt, say "N".
>
> if GOOGLE_FIRMWARE

Prompted by a question downstream in Debian it looks that this patch
never go applied.

Is there anything missing for having it applied?

Do you want a fresh resent of it?

Regards,
Salvatore