From: Borislav Petkov <bp@alien8.de>
To: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Cc: Linux-Kernel <linux-kernel@vger.kernel.org>,
mingo@redhat.com, tglx@linutronix.de,
Srinivas REDDY Eeda <srinivas.eeda@oracle.com>,
hpa@zytor.com
Subject: Re: [PATCH] x86/microcode/intel: Ensure new microcode processor flags match with cpu's pf
Date: Tue, 19 Jun 2018 11:35:52 +0200 [thread overview]
Message-ID: <20180619093552.GB30870@zn.tnic> (raw)
In-Reply-To: <a9c21f46-af2c-28aa-b539-a8b6a6fc666b@oracle.com>
On Tue, Jun 19, 2018 at 05:24:20PM +0800, Zhenzhong Duan wrote:
> On 2018/6/19 17:12, Borislav Petkov wrote:
> > On Tue, Jun 19, 2018 at 12:49:40PM +0800, Zhenzhong Duan wrote:
> > > Imagine kernel already found a microcode blob A with extended sig/pf
> > > matching current cpu, then another microcode B is checked which doesn't
> > > match current cpu...
> > Do you see the
> >
> > if (!microcode_matches(mc_header, uci->cpu_sig.sig)) {
> >
> > call a couple of lines earlier?
> Sure, but it didn't ensure a match in stepping and pf, is that expected?
Do you see the
if (!has_newer_microcode(data,
uci->cpu_sig.sig,
uci->cpu_sig.pf,
uci->cpu_sig.rev))
a couple lines later?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
prev parent reply other threads:[~2018-06-19 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 8:16 [PATCH] x86/microcode/intel: Ensure new microcode processor flags match with cpu's pf Zhenzhong Duan
2018-06-18 19:56 ` Borislav Petkov
2018-06-19 4:49 ` Zhenzhong Duan
2018-06-19 9:12 ` Borislav Petkov
2018-06-19 9:24 ` Zhenzhong Duan
2018-06-19 9:35 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619093552.GB30870@zn.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=srinivas.eeda@oracle.com \
--cc=tglx@linutronix.de \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox