From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: Make CONSOLE_LOGLEVEL_QUIET configurable
Date: Wed, 20 Jun 2018 15:34:30 +0900 [thread overview]
Message-ID: <20180620063430.GA749@jagdpanzerIV> (raw)
In-Reply-To: <20180619093102.5ad9164d@gandalf.local.home>
On (06/19/18 09:31), Steven Rostedt wrote:
> > The goal of passing the "quiet" option to the kernel is for the kernel
> > to be quiet unless something really is wrong.
> >
> > Sofar passing quiet has been (mostly) equivalent to passing
> > loglevel=4 on the kernel commandline. Which means to show any messages
> > with a level of KERN_ERR or higher severity on the console.
> >
> > In practice this often does not result in a quiet boot though, since
> > there are many false-positive or otherwise harmless error messages printed,
> > defeating the purpose of the quiet option. Esp. the ACPICA code is really
> > bad wrt this, but there are plenty of others too.
> >
> > This commit makes CONSOLE_LOGLEVEL_QUIET configurable.
> >
> > This for example will allow distros which want quiet to really mean quiet
> > to set CONSOLE_LOGLEVEL_QUIET so that only messages with a higher severity
> > then KERN_ERR (CRIT, ALERT, EMERG) get printed, avoiding an endless game
> > of whack-a-mole silencing harmless error messages.
> >
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Looks OK to me
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
next prev parent reply other threads:[~2018-06-20 6:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 11:57 [PATCH] printk: Make CONSOLE_LOGLEVEL_QUIET configurable Hans de Goede
2018-06-19 13:31 ` Steven Rostedt
2018-06-20 6:34 ` Sergey Senozhatsky [this message]
2018-06-20 11:03 ` Petr Mladek
2018-06-20 11:24 ` Sergey Senozhatsky
2018-06-20 13:43 ` Hans de Goede
2018-06-21 1:43 ` Sergey Senozhatsky
2018-06-20 13:37 ` Hans de Goede
2018-06-25 14:56 ` Petr Mladek
2018-06-20 14:07 ` Steven Rostedt
2018-06-20 14:18 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620063430.GA749@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox