From: Dan Carpenter <dan.carpenter@oracle.com>
To: John Whitmore <johnfwhitmore@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/9] staging: rtl8192u: Correciton of block comments - Coding Style
Date: Wed, 20 Jun 2018 11:53:01 +0300 [thread overview]
Message-ID: <20180620085301.4yoqdux5s7shedsa@mwanda> (raw)
In-Reply-To: <20180619195605.31321-8-johnfwhitmore@gmail.com>
On Tue, Jun 19, 2018 at 08:56:03PM +0100, John Whitmore wrote:
> @@ -734,16 +734,15 @@ void HTConstructRT2RTAggElement(struct ieee80211_device *ieee, u8 *posRT2RTAgg,
> #ifdef TODO
> #if (HAL_CODE_BASE == RTL8192 && DEV_BUS_TYPE == USB_INTERFACE)
> /*
> - //Emily. If it is required to Ask Realtek AP to send AMPDU during AES mode, enable this
> - section of code.
> + * Emily. If it is required to Ask Realtek AP to send AMPDU during AES
> + * mode, enable this section of code.
> + */
> +#if 0
> if(IS_UNDER_11N_AES_MODE(Adapter))
> - {
> posRT2RTAgg->Octet[5] |=RT_HT_CAP_USE_AMPDU;
> - }else
> - {
> + else
> posRT2RTAgg->Octet[5] &= 0xfb;
> - }
> - */
> +#endif
> #else
> // Do Nothing
> #endif
Please don't introduce new #if 0 blocks. We should just be deleting
ifdeffed out code. It's an almost mindless task. And anyway the #ifdef
TODO works as an #if 0 anyway so this will never be compiled.
regards,
dan carpenter
next prev parent reply other threads:[~2018-06-20 8:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 19:55 v1 Coding style changes John Whitmore
2018-06-19 19:55 ` [PATCH 1/9] staging: rtl8192u: change block comments to prefered style - Coding Style John Whitmore
2018-06-19 19:55 ` [PATCH 2/9] staging: rtl8192u: Correct indentation of switch statement " John Whitmore
2018-06-19 20:07 ` Andy Shevchenko
2018-06-19 19:55 ` [PATCH 3/9] staging: rtl8192u: Truncate block comments to 80 character length - Style John Whitmore
2018-06-19 20:09 ` Andy Shevchenko
2018-06-19 19:56 ` [PATCH 4/9] staging: rtl8192u: Removal of white space from end of lines - Coding Style John Whitmore
2018-06-19 19:56 ` [PATCH 5/9] staging: rtl8192u: Use %s and __func__ instead of hardcoded string - Style John Whitmore
2018-06-19 20:19 ` Andy Shevchenko
2018-06-19 19:56 ` [PATCH 6/9] staging: rtl8192u: Remove braces from single statement blocks " John Whitmore
2018-06-19 19:56 ` [PATCH 7/9] staging: rtl8192u: Correciton of block comments - Coding Style John Whitmore
2018-06-20 8:53 ` Dan Carpenter [this message]
2018-06-19 19:56 ` [PATCH 8/9] staging: rtl8192u: Correct if statement " John Whitmore
2018-06-19 19:56 ` [PATCH 9/9] staging: rtl8192u: Correction of spelling mistake in comment John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620085301.4yoqdux5s7shedsa@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnfwhitmore@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox