public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Karoly Pados <pados@pados.hu>
Cc: Johan Hovold <johan@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: cp210x: Improve baudrate support for CP2102N
Date: Wed, 20 Jun 2018 12:57:39 +0200	[thread overview]
Message-ID: <20180620105739.GR32411@localhost> (raw)
In-Reply-To: <b82f656ba4c2c05d86ae7149be4109c6@pados.hu>

On Wed, Jun 20, 2018 at 09:51:41AM +0000, Karoly Pados wrote:
> > By the way, have you tried setting other baudrates except the ones you
> > explicitly allow for here? According to the data sheet more rates should
> > be available, so perhaps just handling cp2102n as cp2108 (e.g. by not
> > trying to report back the exact rate used) or by actually calculating
> > the resulting rate could be another option?
> > 
> > Can be done later of course, just curious if you tried it.
> 
> Yeah I know, I was thinking about this too while developing the patch. 
> Officially the cp2102 and the cp2102n are fully software compatible (aside
> from baudrate aliasing), but if the cp2102n chooses different baudrates for 
> the same inputs than the older devices would then they couldn't/wouldn't be
> compatible. So I concluded it must also be doing the quantisation.

Yeah, that's probably right, but the older devices do not support
rates > 1 Mbaud so that logic does not necessarily apply there.

> Maybe I am too naive and trust the datasheet to much. I'll do some
> measurements with my scope and let you know the results.

Cool. We can keep the old behaviour for < 1Mbaud, but it would be nice
to know if you can generate rates other than the 4-5 +1Mbauds rates that
were explicitly mentioned in the data sheet.

Thanks,
Johan

      reply	other threads:[~2018-06-20 10:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-15 21:29 [PATCH] USB: serial: cp210x: Improve baudrate support for CP2102N Karoly Pados
2018-06-19  9:15 ` Johan Hovold
2018-06-19  9:50   ` Karoly Pados
2018-06-20  9:39     ` Johan Hovold
2018-06-20  9:51       ` Karoly Pados
2018-06-20 10:57         ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180620105739.GR32411@localhost \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pados@pados.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox