From: Byungchul Park <byungchul.park@lge.com>
To: Byungchul Park <max.byungchul.park@gmail.com>,
peterz@infradead.org, mingo@kernel.org
Cc: Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Dario Faggioli <raistlin@linux.it>,
linux-kernel@vger.kernel.org, Juri Lelli <juri.lelli@gmail.com>,
bristot@redhat.com, kernel-team@lge.com,
Joel Fernandes <joel@joelfernandes.org>
Subject: Re: [RESEND PATCH v12 2/2] sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq()
Date: Wed, 20 Jun 2018 21:51:42 +0900 [thread overview]
Message-ID: <20180620125142.GA21889@X58A-UD3R> (raw)
In-Reply-To: <CANrsvROOfkPw265ObAPJ_H2epP2SJJsV64xcAGvOCbqHgwny1w@mail.gmail.com>
On Tue, Jun 19, 2018 at 02:16:36PM +0900, Byungchul Park wrote:
> On Tue, Jun 19, 2018 at 6:42 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Mon, 18 Jun 2018 13:58:09 +0900
> > Byungchul Park <byungchul.park@lge.com> wrote:
> >
> >> Hello Steven,
> >>
> >> I've changed the code a little bit to avoid a compile warning caused by
> >> 'const' args of find_cpu(). Can I keep your Reviewed-by?
> >>
> >> BEFORE:
> >> static int find_cpu(const struct cpumask *mask,
> >> const struct sched_domain *sd,
> >> const struct sched_domain *prefer)
> >>
> >> AFTER:
> >> static int find_cpu(const struct cpumask *mask,
> >> struct sched_domain *sd,
> >> struct sched_domain *prefer)
> >>
> >> (I temporarily removed the Reviewed-by you gave me.)
> >> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> >
> > I would fix sched_domain_span() to take a constant and keep the
> > previous patch.
>
> Right. I also considered it like you and asked it here:
>
> https://lkml.org/lkml/2018/1/11/106
>
> But I didn't get any answer so tried to keep sched_domain_span()
> unchanged conservatively.
>
> Peterz, what's your opinion?
Peterz and Ingo,
I cannot progress forward without your opinion. Please your opinion.
> > -- Steve
>
> --
> Thanks,
> Byungchul
next prev parent reply other threads:[~2018-06-20 12:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 4:58 [RESEND PATCH v12 0/2] Make find_later_rq() choose a closer cpu in topology Byungchul Park
2018-06-18 4:58 ` [RESEND PATCH v12 1/2] sched/deadline: Add support for SD_PREFER_SIBLING on find_later_rq() Byungchul Park
2018-06-18 21:36 ` Steven Rostedt
2018-06-18 4:58 ` [RESEND PATCH v12 2/2] sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq() Byungchul Park
2018-06-18 21:42 ` Steven Rostedt
2018-06-19 5:16 ` Byungchul Park
2018-06-20 12:51 ` Byungchul Park [this message]
2018-06-26 8:30 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620125142.GA21889@X58A-UD3R \
--to=byungchul.park@lge.com \
--cc=bristot@redhat.com \
--cc=joel@joelfernandes.org \
--cc=juri.lelli@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=max.byungchul.park@gmail.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=raistlin@linux.it \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox