public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
	David Sterba <dsterba@suse.com>,
	y2038@lists.linaro.org, Anand Jain <anand.jain@oracle.com>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] btrfs: use 64-bit timestamps for struct btrfs_dev_replace_item
Date: Wed, 20 Jun 2018 16:36:55 +0200	[thread overview]
Message-ID: <20180620143655.GD24375@twin.jikos.cz> (raw)
In-Reply-To: <20180620143448.44388-2-arnd@arndb.de>

On Wed, Jun 20, 2018 at 04:34:33PM +0200, Arnd Bergmann wrote:
> The structure already has 64-bit fields for the timestamps, but
> calling get_seconds() may truncate and risk overflow on 32-bit
> architectures.
> 
> This changes the dev-replace code to use ktime_get_real_seconds()
> instead, which always returns 64-bit timestamps.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks but there's a patch already fixng that, sent a few days ago

https://patchwork.kernel.org/patch/10473195/

and added to patch queue for the next dev cycle as it does not appear to
urgent for 4.18.

  reply	other threads:[~2018-06-20 14:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20 14:34 [PATCH 1/3] btrfs: use monotonic time for transaction handling Arnd Bergmann
2018-06-20 14:34 ` [PATCH 2/3] btrfs: use 64-bit timestamps for struct btrfs_dev_replace_item Arnd Bergmann
2018-06-20 14:36   ` David Sterba [this message]
2018-06-20 15:15     ` Arnd Bergmann
2018-06-20 14:34 ` [PATCH 3/3] btrfs: use timespec64 for i_otime Arnd Bergmann
2018-06-20 16:38   ` David Sterba
2018-06-20 19:34     ` Nikolay Borisov
2018-06-20 19:41       ` Arnd Bergmann
2018-06-21  8:23         ` Nikolay Borisov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180620143655.GD24375@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=anand.jain@oracle.com \
    --cc=arnd@arndb.de \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=jbacik@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox