From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3C2BC1B0F2 for ; Wed, 20 Jun 2018 14:42:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7008420836 for ; Wed, 20 Jun 2018 14:42:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7008420836 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754243AbeFTOmY (ORCPT ); Wed, 20 Jun 2018 10:42:24 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:38334 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753952AbeFTOmX (ORCPT ); Wed, 20 Jun 2018 10:42:23 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B39FC80D; Wed, 20 Jun 2018 07:42:22 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7842D3F589; Wed, 20 Jun 2018 07:42:22 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 627B71AE2E3D; Wed, 20 Jun 2018 15:42:58 +0100 (BST) Date: Wed, 20 Jun 2018 15:42:58 +0100 From: Will Deacon To: Wei Xu Cc: catalin.marinas@arm.com, suzuki.poulose@arm.com, dave.martin@arm.com, mark.rutland@arm.com, james.morse@arm.com, marc.zyngier@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linuxarm , Hanjun Guo , xiexiuqi@huawei.com, huangdaode , "Chenxin (Charles)" , "Xiongfanggou (James)" , "Liguozhu (Kenneth)" , Zhangyi ac , jonathan.cameron@huawei.com, Shameerali Kolothum Thodi , John Garry , Salil Mehta , Shiju Jose , "Zhuangyuzeng (Yisen)" , "Wangzhou (B)" , "kongxinwei (A)" , "Liyuan (Larry, Turing Solution)" , libeijian@hisilicon.com Subject: Re: KVM guest sometimes failed to boot because of kernel stack overflow if KPTI is enabled on a hisilicon ARM64 platform. Message-ID: <20180620144257.GB27776@arm.com> References: <5B2A6218.3030201@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5B2A6218.3030201@hisilicon.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wei, On Wed, Jun 20, 2018 at 10:18:00PM +0800, Wei Xu wrote: > We have observed KVM guest sometimes failed to boot because of kernel stack > overflow if KPTI is enabled on a hisilicon arm64 platform. > > We also tested with different kernel version and found it is only > happened if the KPTI and KVM(enable-kvm & cpu=host) are enabled on the > guest. > The detail result is as below table. > > +---------+----------+--------+------------+-------------------+ > | host |host KPTI | guest | guest KPTI | kvm guest | > | kernel |enabled | kernel | enabled | booting result | > +---------+----------+--------+------------+-------------------+ > | 4.17 | Y | 4.17 | Y | stack overflow | > +---------+----------+--------+------------+-------------------+ > | 4.17 | Y | 4.16 | NA | OK | > +---------+----------+--------+------------+-------------------+ > | 4.16 | NA | 4.17 | Y | stack overflow | > +---------+----------+--------+------------+-------------------+ > | 4.16 | NA | 4.16 | NA | OK | > +---------+----------+--------+------------+-------------------+ > > A simple walk-around is adding this platform into the "kpti_safe_list". > But it does not resolve the issue indeed. > Could you please share any hint how to resolve this kind issue? > Thanks! > > Another issue we found is "kpti_install_ng_mappings" will be invoked > even "kpti=off" has been added in the kernel command line. Is that expected? > This is because "kpti" is not a *early* param that "init_cpu_features" will > be invoked before parsing the param. That sounds like a straightforward bug, which means we should use early_param instead of __setup. I assume that doesn't fix your crash, though? > The command we are using to run the guest is as: > > ./qemu-system-aarch64 -machine virt,kernel_irqchip=on,gic-version=3 -cpu > host > -enable-kvm -smp 1 -m 1024 -kernel ./Image -initrd > ../mini-rootfs-arm64.cpio.gz > -nographic -append "rdinit=init console=ttyAMA0 > earlycon=pl011,0x9000000" > > The log is as below: > > [ 0.000000] Booting Linux on physical CPU 0x0000000000 > [0x480fd010] > [ 0.000000] Linux version 4.17.0-45864-g29dcea8-dirty > (joyx@Turing-Arch-b) (gcc version 4.9.1 20140505 (prerelease) (crosstool-NG > linaro-1.13.1-4.9-2014.05 - Linaro GCC 4.9-2014.05)) #6 SMP PREEMPT Fri Jun > 15 21:39:52 CST 2018 ^^^ This is reproducible with vanilla v4.17 and defconfig, right? > [ 0.038859] SMP: Total of 1 processors activated. > [ 0.039338] CPU features: detected: GIC system register CPU > interface > [ 0.039988] CPU features: detected: Privileged Access Never > [ 0.040560] CPU features: detected: User Access Override > [ 0.041093] CPU features: detected: RAS Extension Support > [ 0.042947] Insufficient stack space to handle exception! > [ 0.042949] ESR: 0x96000046 -- DABT (current EL) > [ 0.043963] FAR: 0xffff0000093a80e0 > [ 0.045794] Task stack: [0xffff0000093a8000..0xffff0000093ac000] > [ 0.052181] IRQ stack: [0xffff000008000000..0xffff000008004000] > [ 0.058572] Overflow stack: > [0xffff80003efce2f0..0xffff80003efcf2f0] > [ 0.065068] CPU: 0 PID: 12 Comm: migration/0 Not tainted > 4.17.0-45864-g29dcea8-dirty #6 > [ 0.073138] Hardware name: linux,dummy-virt (DT) > [ 0.077831] pstate: 604003c5 (nZCv DAIF +PAN -UAO) > [ 0.082661] pc : el1_sync+0x0/0xb0 > [ 0.086152] lr : kpti_install_ng_mappings+0x120/0x214 Can you use scripts/faddr2line to find out which line of code the lr is pointing at, please? It would be interesting to know if we managed to install the idmap. Hmm, I wonder if this is at all related to RAS, since we've just enabled that and if we take a fault whilst rewriting swapper then we're going to get stuck. What happens if you set CONFIG_ARM64_RAS_EXTN=n in the guest? Will