From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: linux-integrity@vger.kernel.org, jarkko.sakkinen@linux.intel.com,
zohar@linux.vnet.ibm.com
Cc: jgg@ziepe.ca, linux-kernel@vger.kernel.org,
Stefan Berger <stefanb@linux.vnet.ibm.com>
Subject: [PATCH 1/6] tpm: Introduce a kref for the tpm_chip
Date: Wed, 20 Jun 2018 12:19:43 -0400 [thread overview]
Message-ID: <20180620161948.1464255-2-stefanb@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180620161948.1464255-1-stefanb@linux.vnet.ibm.com>
Introduce a kref for the tpm_chip that we initialize when the tpm_chip has
been allocated and release before the tpm_chip is to be freed.
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
---
drivers/char/tpm/tpm-chip.c | 24 +++++++++++++++++++-----
drivers/char/tpm/tpm.h | 1 +
2 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
index 0a62c19937b6..a933676194a4 100644
--- a/drivers/char/tpm/tpm-chip.c
+++ b/drivers/char/tpm/tpm-chip.c
@@ -119,8 +119,24 @@ struct tpm_chip *tpm_chip_find_get(struct tpm_chip *chip)
return res;
}
+static void tpm_chip_free(struct kref *kref)
+{
+ struct tpm_chip *chip = container_of(kref, struct tpm_chip, kref);
+
+ kfree(chip->log.bios_event_log);
+ kfree(chip->work_space.context_buf);
+ kfree(chip->work_space.session_buf);
+ kfree(chip);
+}
+
+static void tpm_chip_put(struct tpm_chip *chip)
+{
+ if (chip)
+ kref_put(&chip->kref, tpm_chip_free);
+}
+
/**
- * tpm_dev_release() - free chip memory and the device number
+ * tpm_dev_release() - free the device number and release reference to chip
* @dev: the character device for the TPM chip
*
* This is used as the release function for the character device.
@@ -133,10 +149,7 @@ static void tpm_dev_release(struct device *dev)
idr_remove(&dev_nums_idr, chip->dev_num);
mutex_unlock(&idr_lock);
- kfree(chip->log.bios_event_log);
- kfree(chip->work_space.context_buf);
- kfree(chip->work_space.session_buf);
- kfree(chip);
+ tpm_chip_put(chip);
}
static void tpm_devs_release(struct device *dev)
@@ -195,6 +208,7 @@ struct tpm_chip *tpm_chip_alloc(struct device *pdev,
mutex_init(&chip->tpm_mutex);
init_rwsem(&chip->ops_sem);
+ kref_init(&chip->kref);
chip->ops = ops;
diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
index 7f2d0f489e9c..098d7dcc04a4 100644
--- a/drivers/char/tpm/tpm.h
+++ b/drivers/char/tpm/tpm.h
@@ -211,6 +211,7 @@ struct tpm_chip {
struct cdev cdev;
struct cdev cdevs;
+ struct kref kref;
/* A driver callback under ops cannot be run unless ops_sem is held
* (sometimes implicitly, eg for the sysfs code). ops becomes null
* when the driver is unregistered, see tpm_try_get_ops.
--
2.13.6
next prev parent reply other threads:[~2018-06-20 16:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 16:19 [PATCH 0/6] Have IMA find and use a tpm_chip until system shutdown Stefan Berger
2018-06-20 16:19 ` Stefan Berger [this message]
2018-06-20 18:38 ` [PATCH 1/6] tpm: Introduce a kref for the tpm_chip Jason Gunthorpe
2018-06-20 19:34 ` Stefan Berger
2018-06-21 16:50 ` Jarkko Sakkinen
2018-06-20 16:19 ` [PATCH 2/6] tpm: Get additional kref with every call to tpm_try_get_ops() Stefan Berger
2018-06-20 16:19 ` [PATCH 3/6] tpm: Implement tpm_chip_find() for other subsystems to call Stefan Berger
2018-06-20 16:19 ` [PATCH 4/6] ima: Implement ima_shutdown and register it as a reboot_notifier Stefan Berger
2018-06-20 16:19 ` [PATCH 5/6] ima: Use tpm_chip_find() and access TPM functions using it Stefan Berger
2018-06-20 16:19 ` [PATCH 6/6] ima: Get rid of ima_used_chip and use ima_tpm_chip != NULL instead Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620161948.1464255-2-stefanb@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox