public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org,
	Gwendal Grignou <gwendal@chromium.org>,
	Benson Leung <bleung@chromium.org>
Subject: [PATCH 1/2] Revert "mfd: cros_ec: Remove unused __remove function"
Date: Wed, 20 Jun 2018 14:30:32 -0700	[thread overview]
Message-ID: <20180620213033.100455-1-dmitry.torokhov@gmail.com> (raw)

This reverts commit 556c242045f0c1613aac2e64dc5b2ff0e4bc89e1.

The patch that this change is purported to fix is broken and should be
reverted; thus we reverting this one as well.
---

Lee,

I see the broken code is already in Linus' tree, so please merge send
it on at your earliest convenience.

Thanks,
Dmitry


 drivers/mfd/cros_ec_dev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index 306e1fd109bd..4b1dbe81fcb6 100644
--- a/drivers/mfd/cros_ec_dev.c
+++ b/drivers/mfd/cros_ec_dev.c
@@ -262,6 +262,8 @@ static const struct file_operations fops = {
 #endif
 };
 
+static void __remove(struct device *dev) { }
+
 static void cros_ec_sensors_register(struct cros_ec_dev *ec)
 {
 	/*
-- 
2.18.0.rc1.244.gcf134e6275-goog


             reply	other threads:[~2018-06-20 21:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20 21:30 Dmitry Torokhov [this message]
2018-06-20 21:30 ` [PATCH 2/2] Revert "mfd: cros_ec: Use devm_kzalloc for private data" Dmitry Torokhov
2018-07-04  7:00   ` Lee Jones
2018-07-04  6:48 ` [PATCH 1/2] Revert "mfd: cros_ec: Remove unused __remove function" Lee Jones
2018-07-04 15:16   ` Dmitry Torokhov
2018-07-04 16:11     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180620213033.100455-1-dmitry.torokhov@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bleung@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox