From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C07D7C43141 for ; Thu, 21 Jun 2018 06:41:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 701DA20883 for ; Thu, 21 Jun 2018 06:41:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="IpX+aPGV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 701DA20883 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932564AbeFUGli (ORCPT ); Thu, 21 Jun 2018 02:41:38 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:35542 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751321AbeFUGlh (ORCPT ); Thu, 21 Jun 2018 02:41:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4fzL+BRh8IfVJQYasBAcv95DF1JHLlYLCZ0mGflOQCw=; b=IpX+aPGVfCPIjYS2DH75eg/RW oOt8N3CplUqdg+RtIDRqrg5bGdNFSgRtaAE5HTYTkZ1cG4A+NhBM2cAy+iHLHZZEfjtmNLJ8AEeIx QZjllryLRsqTl5pD4MFOTuZwoXy3K89BTrMPD6X88pBmYpOH2LJBUi2nJ8yuqPPxVSi4vtRLKzxT8 d5xBhwrgcB4Fnd2/wWtXEO/UiPmKi3t1T8j9oXNDSQRqeqmqlq38snoOZwDmIggUK8fOXzccZOlCi FIgnM1YFsnp6k6+f7vroVUnpCQbCutaSEjFvfZTi8eaYr56sQQw/7eC8/spswEVDROPCUDN1s/uE/ RQxajHxUA==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fVtHk-0003xd-6F; Thu, 21 Jun 2018 06:41:36 +0000 Date: Wed, 20 Jun 2018 23:41:35 -0700 From: Christoph Hellwig To: Zong Li Cc: palmer@sifive.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, greentime@adnestech.com Subject: Re: [PATCH 4/5] RISC-V: Change variable type for 32-bit compatible Message-ID: <20180621064135.GD19319@infradead.org> References: <3f86f9eb853380686a86a8abe6bda0dd3720ee10.1529506497.git.zong@andestech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f86f9eb853380686a86a8abe6bda0dd3720ee10.1529506497.git.zong@andestech.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > - s64 offset = (void *)v - (void *)location; > + uintptr_t offset = (void *)v - (void *)location; s64 is signed, uintptr is not, so this might change behavior and needs an explanation.