From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Dmitry Vyukov <dvyukov@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH] arch/x86: get rid of KERN_CONT in show_fault_oops()
Date: Thu, 21 Jun 2018 17:17:04 +0900 [thread overview]
Message-ID: <20180621081704.GA677@jagdpanzerIV> (raw)
In-Reply-To: <CACT4Y+bjdmgdeRLM5kBaf6-vunFwFRD0_zCZX=A-rY+XEEfnEA@mail.gmail.com>
On (06/21/18 09:59), Dmitry Vyukov wrote:
> >
> >> + printk(KERN_ALERT "BUG: unable to handle kernel %s at %px\n",
> >> + (address < PAGE_SIZE ? "NULL pointer dereference" :
> >> + "paging request"), (void *) address);
> >
> > Perhaps pr_alert() ?
>
> It's the same, right? Make sense.
Right.
In printk(KERN_<LEVEL> ...) people tend to forget KERN_<LEVEL> sometimes,
so, I think, in general we want to see more pr_foo() and less printk().
-ss
next prev parent reply other threads:[~2018-06-21 8:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 12:55 [PATCH] arch/x86: get rid of KERN_CONT in show_fault_oops() Dmitry Vyukov
2018-06-21 1:06 ` Andy Shevchenko
2018-06-21 7:59 ` Dmitry Vyukov
2018-06-21 8:17 ` Sergey Senozhatsky [this message]
2018-06-25 12:40 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621081704.GA677@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=dvyukov@gmail.com \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox