From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA2D3C43141 for ; Thu, 21 Jun 2018 10:23:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A40C820883 for ; Thu, 21 Jun 2018 10:23:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A40C820883 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754236AbeFUKX2 (ORCPT ); Thu, 21 Jun 2018 06:23:28 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35778 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752926AbeFUKX1 (ORCPT ); Thu, 21 Jun 2018 06:23:27 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E19C24021FC9; Thu, 21 Jun 2018 10:23:26 +0000 (UTC) Received: from localhost (ovpn-8-18.pek2.redhat.com [10.72.8.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 29E561117637; Thu, 21 Jun 2018 10:23:23 +0000 (UTC) Date: Thu, 21 Jun 2018 18:23:21 +0800 From: Baoquan He To: lijiang Cc: linux-kernel@vger.kernel.org, thomas.lendacky@amd.com, iommu@lists.linux-foundation.org, dyoung@redhat.com, kexec@lists.infradead.org Subject: Re: [PATCH 2/4 V3] Allocate pages for kdump without encryption when SME is enabled Message-ID: <20180621102321.GK29979@MiWiFi-R3L-srv> References: <20180616082714.32035-1-lijiang@redhat.com> <20180616082714.32035-3-lijiang@redhat.com> <20180621015306.GG29979@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 21 Jun 2018 10:23:26 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 21 Jun 2018 10:23:26 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'bhe@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/21/18 at 01:06pm, lijiang wrote: > 在 2018年06月21日 09:53, Baoquan He 写道: > > On 06/16/18 at 04:27pm, Lianbo Jiang wrote: > >> When SME is enabled in the first kernel, we will allocate pages > >> for kdump without encryption in order to be able to boot the > >> second kernel in the same manner as kexec, which helps to keep > >> the same code style. > >> > >> Signed-off-by: Lianbo Jiang > >> --- > >> kernel/kexec_core.c | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c > >> index 20fef1a..3c22a9b 100644 > >> --- a/kernel/kexec_core.c > >> +++ b/kernel/kexec_core.c > >> @@ -471,6 +471,16 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image, > >> } > >> } > >> > >> + if (pages) { > >> + unsigned int count, i; > >> + > >> + pages->mapping = NULL; > >> + set_page_private(pages, order); > >> + count = 1 << order; > >> + for (i = 0; i < count; i++) > >> + SetPageReserved(pages + i); > > > > I guess you might imitate the kexec case, however kexec get pages from > > buddy. Crash pages are reserved in memblock, these codes might make no sense. > > > Thanks for your comments. > We have changed the attribute of pages, so the original attribute of pages will be > restored when they free. Hmm, you can check what kimage_free() is doing, and where kimage->control_pages, dest_pages, unusable_pages is assigned. Do you know where these original attribute of pages comes from and they are used/needed in CRASH case, if you care about them? > > >> + arch_kexec_post_alloc_pages(page_address(pages), 1 << order, 0); > >> + } > >> return pages; > >> } > >> > >> @@ -865,6 +875,7 @@ static int kimage_load_crash_segment(struct kimage *image, > >> result = -ENOMEM; > >> goto out; > >> } > >> + arch_kexec_post_alloc_pages(page_address(page), 1, 0); > >> ptr = kmap(page); > >> ptr += maddr & ~PAGE_MASK; > >> mchunk = min_t(size_t, mbytes, > >> @@ -882,6 +893,7 @@ static int kimage_load_crash_segment(struct kimage *image, > >> result = copy_from_user(ptr, buf, uchunk); > >> kexec_flush_icache_page(page); > >> kunmap(page); > >> + arch_kexec_pre_free_pages(page_address(page), 1); > >> if (result) { > >> result = -EFAULT; > >> goto out; > >> -- > >> 2.9.5 > >> > >> > >> _______________________________________________ > >> kexec mailing list > >> kexec@lists.infradead.org > >> http://lists.infradead.org/mailman/listinfo/kexec