Re: [PATCHv4 1/3] scripts: Preprocess module-common.lds

Masahiro Yamada
2018-06-13T02:04:14Z

2018-06-12 9:32 GMT+09:00 Laura Abbott <labbott@redhat.com>:
>
> In preparation for some upcoming work, allow module-common.lds
> to be run through the preprocessor.
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> scripts/.gitignore | 1 +
> scripts/Makefile | 2 +-
> scripts/{module-common.lds => module-common.lds.S} | 0
> 3 files changed, 2 insertions(+), 1 deletion(-)
> rename scripts/{module-common.lds => module-common.lds.S} (100%)
>
> diff --git a/scripts/.gitignore b/scripts/.gitignore
> index 0442c06eefcb..afd1de57d9c6 100644
> --- a/scripts/.gitignore
> +++ b/scripts/.gitignore
> @@ -13,3 +13,4 @@ asn1_compiler
> extract-cert
> sign-file
> insert-sys-cert
> +module-common.lds
> diff --git a/scripts/Makefile b/scripts/Makefile
> index 25ab143cbe14..631d9d1a71e4 100644
> --- a/scripts/Makefile
> +++ b/scripts/Makefile
> @@ -25,7 +25,7 @@ HOSTCFLAGS_asn1_compiler.o = -I$(srctree)/include
> HOSTLOADLIBES_sign-file = -lcrypto
> HOSTLOADLIBES_extract-cert = -lcrypto
>
> -always := $(hostprogs-y) $(hostprogs-m)
> +always := $(hostprogs-y) $(hostprogs-m) module-common.lds

You do not need to generate module-common.lds all the time.
It is necessary only when the module feature is enabled.

You can do like this:

extra-$(CONFIG_MODULES) += module-common.lds

--
Best Regards
Masahiro Yamada