From: Ingo Molnar <mingo@kernel.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Joel Fernandes <joel.opensrc@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Chris Zankel <chris@zankel.net>,
Paul Mackerras <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will.deacon@arm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Rich Felker <dalias@libc.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: [GIT PULL] breakpoint: Rework arch validation v3
Date: Thu, 21 Jun 2018 15:37:41 +0200 [thread overview]
Message-ID: <20180621133741.GA24944@gmail.com> (raw)
In-Reply-To: <1527863526-32677-1-git-send-email-frederic@kernel.org>
* Frederic Weisbecker <frederic@kernel.org> wrote:
> Ingo,
>
> Please pull the perf/breakpoint-v3 branch that can be found at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> perf/breakpoint-v3
>
> HEAD: 3c0681cc01b39e7fac6eb810e82380165c9b56f1
>
> Changes since v2:
>
> * Constify the struct perf_event_attr passed in hw_breakpoint_parse()
> * Add acks
>
> ---
> When we modify a hardware breakpoint, the architecture code fills up
> the architecture data as the validation of generic attributes progresses.
> If something goes wrong in the middle, the architecture data changes
> aren't rolled back and we are left with a halfway fiddled breakpoint.
>
> This set fixes the various misdesigns that back this bad behaviour.
>
> Thanks,
> Frederic
> ---
>
> Frederic Weisbecker (12):
> perf/breakpoint: Split attribute parse and commit
> perf/breakpoint: Pass arch breakpoint struct to arch_check_bp_in_kernelspace()
> x86: Implement hw_breakpoint_arch_parse()
> powerpc: Implement hw_breakpoint_arch_parse()
> arm: Implement hw_breakpoint_arch_parse()
> arm64: Implement hw_breakpoint_arch_parse()
> sh: Remove "struct arch_hw_breakpoint::name" unused field
> sh: Implement hw_breakpoint_arch_parse()
> xtensa: Implement hw_breakpoint_arch_parse()
> perf/breakpoint: Remove default hw_breakpoint_arch_parse()
> perf/breakpoint: Pass new breakpoint type to modify_breakpoint_slot()
> perf/breakpoint: Clean up and consolidate modify_user_hw_breakpoint_check()
>
>
> arch/arm/include/asm/hw_breakpoint.h | 7 +-
> arch/arm/kernel/hw_breakpoint.c | 78 +++++++++---------
> arch/arm64/include/asm/hw_breakpoint.h | 7 +-
> arch/arm64/kernel/hw_breakpoint.c | 86 ++++++++++----------
> arch/powerpc/include/asm/hw_breakpoint.h | 7 +-
> arch/powerpc/kernel/hw_breakpoint.c | 47 ++++++-----
> arch/sh/include/asm/hw_breakpoint.h | 8 +-
> arch/sh/kernel/hw_breakpoint.c | 53 ++++++-------
> arch/x86/include/asm/hw_breakpoint.h | 7 +-
> arch/x86/kernel/hw_breakpoint.c | 131 ++++++++++++++++---------------
> arch/xtensa/include/asm/hw_breakpoint.h | 7 +-
> arch/xtensa/kernel/hw_breakpoint.c | 40 ++++------
> kernel/events/hw_breakpoint.c | 92 +++++++++++++---------
> 13 files changed, 294 insertions(+), 276 deletions(-)
Ok, this looks pretty good.
I was trying to apply this series today, but got a few conflicts due to new
changes in the merge window, in:
arch/sh/kernel/hw_breakpoint.c
arch/powerpc/kernel/hw_breakpoint.c
Could you please resolve those conflicts and resend the series?
Thanks!
Ingo
prev parent reply other threads:[~2018-06-21 13:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 14:31 [GIT PULL] breakpoint: Rework arch validation v3 Frederic Weisbecker
2018-06-01 14:31 ` [PATCH 01/12] perf/breakpoint: Split attribute parse and commit Frederic Weisbecker
2018-06-01 14:31 ` [PATCH 02/12] perf/breakpoint: Pass arch breakpoint struct to arch_check_bp_in_kernelspace() Frederic Weisbecker
2018-06-01 14:31 ` [PATCH 03/12] x86: Implement hw_breakpoint_arch_parse() Frederic Weisbecker
2018-06-01 14:31 ` [PATCH 04/12] powerpc: " Frederic Weisbecker
2018-06-01 14:31 ` [PATCH 05/12] arm: " Frederic Weisbecker
2018-06-01 14:31 ` [PATCH 06/12] arm64: " Frederic Weisbecker
2018-06-01 14:32 ` [PATCH 07/12] sh: Remove "struct arch_hw_breakpoint::name" unused field Frederic Weisbecker
2018-06-01 14:32 ` [PATCH 08/12] sh: Implement hw_breakpoint_arch_parse() Frederic Weisbecker
2018-06-01 14:32 ` [PATCH 09/12] xtensa: " Frederic Weisbecker
2018-06-01 14:32 ` [PATCH 10/12] perf/breakpoint: Remove default hw_breakpoint_arch_parse() Frederic Weisbecker
2018-06-01 14:32 ` [PATCH 11/12] perf/breakpoint: Pass new breakpoint type to modify_breakpoint_slot() Frederic Weisbecker
2018-06-01 14:32 ` [PATCH 12/12] perf/breakpoint: Clean up and consolidate modify_user_hw_breakpoint_check() Frederic Weisbecker
2018-06-21 13:37 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621133741.GA24944@gmail.com \
--to=mingo@kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=chris@zankel.net \
--cc=dalias@libc.org \
--cc=frederic@kernel.org \
--cc=jcmvbkbc@gmail.com \
--cc=joel.opensrc@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox