From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Jiri Slaby <jslaby@suse.cz>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
mingo@redhat.com, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Subject: Re: [PATCH v3 1/6] x86/stacktrace: do not unwind after user regs
Date: Thu, 21 Jun 2018 16:35:30 +0200 [thread overview]
Message-ID: <20180621143530.GA14228@gmail.com> (raw)
In-Reply-To: <20180531134642.sl2ezvng2cdsyklk@treble>
* Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> On Tue, May 22, 2018 at 11:06:09AM -0500, Josh Poimboeuf wrote:
> > On Sat, May 19, 2018 at 09:42:51AM +0200, Ingo Molnar wrote:
> > >
> > > * Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > >
> > > > On Fri, May 18, 2018 at 08:55:47AM +0200, Ingo Molnar wrote:
> > > > >
> > > > > * Jiri Slaby <jslaby@suse.cz> wrote:
> > > > >
> > > > > > Josh pointed out, that there is no way a frame can be after user regs.
> > > > > > So remove the last unwind and the check.
> > > > > >
> > > > > > Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> > > > > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > > > > Cc: Ingo Molnar <mingo@redhat.com>
> > > > > > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > > > > > Cc: x86@kernel.org
> > > > > > Cc: Josh Poimboeuf <jpoimboe@redhat.com>
> > > > >
> > > > > Josh: an Acked-by or Reviewed-by for the whole series from you would be nice.
> > > >
> > > > The patches look good, but I want to run it through some testing before
> > > > I give them an ACK.
> >
> > For the series:
> >
> > Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
>
> Ingo,
>
> Any chance this can make the next merge window?
Applied now - will push it out after testing.
Thanks,
Ingo
prev parent reply other threads:[~2018-06-21 14:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 6:47 [PATCH v3 1/6] x86/stacktrace: do not unwind after user regs Jiri Slaby
2018-05-18 6:47 ` [PATCH v3 2/6] x86/stacktrace: remove STACKTRACE_DUMP_ONCE Jiri Slaby
2018-05-18 6:47 ` [PATCH v3 3/6] x86/stacktrace: clarify the reliable success paths Jiri Slaby
2018-05-18 6:47 ` [PATCH v3 4/6] x86/stacktrace: do not fail for ORC with regs on stack Jiri Slaby
2018-05-18 6:47 ` [PATCH v3 5/6] x86/unwind/orc: Detect the end of the stack Jiri Slaby
2018-05-18 6:47 ` [PATCH v3 6/6] x86/stacktrace: enable HAVE_RELIABLE_STACKTRACE for the ORC unwinder Jiri Slaby
2018-05-18 6:55 ` [PATCH v3 1/6] x86/stacktrace: do not unwind after user regs Ingo Molnar
2018-05-18 22:41 ` Josh Poimboeuf
2018-05-19 7:42 ` Ingo Molnar
2018-05-22 16:06 ` Josh Poimboeuf
2018-05-31 13:46 ` Josh Poimboeuf
2018-06-21 14:35 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621143530.GA14228@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox