From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Louis Collard <louiscollard@chromium.org>,
linux-integrity@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, apronin@chromium.org
Subject: Re: [PATCH] tpm: Add module parameter for hwrng quality.
Date: Thu, 21 Jun 2018 19:21:01 +0300 [thread overview]
Message-ID: <20180621162101.GB11859@linux.intel.com> (raw)
In-Reply-To: <20180618193306.GF6805@ziepe.ca>
On Mon, Jun 18, 2018 at 01:33:06PM -0600, Jason Gunthorpe wrote:
> > > +module_param(override_rng_quality, short, 0644);
> >
> > Should this be 600 i.e. not to leak this information?
>
> There is a real push these days against adding module parameters, and
> apparently, IMA can't function with TPM as a module.
>
> Are you sure this shouldn't be done in some other way?
Maybe a sysfs file would be a better choice for this?
/Jarkko
next prev parent reply other threads:[~2018-06-21 16:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 6:54 [PATCH] tpm: Add module parameter for hwrng quality Louis Collard
2018-06-18 18:07 ` Jarkko Sakkinen
2018-06-18 19:33 ` Jason Gunthorpe
2018-06-21 16:21 ` Jarkko Sakkinen [this message]
2018-06-27 6:11 ` Louis Collard
2018-06-29 13:03 ` David R. Bild
2018-07-04 6:54 ` Louis Collard
2018-07-18 2:43 ` David R. Bild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621162101.GB11859@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=apronin@chromium.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louiscollard@chromium.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox