From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4B95C43140 for ; Thu, 21 Jun 2018 16:21:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 858CF21524 for ; Thu, 21 Jun 2018 16:21:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 858CF21524 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933463AbeFUQVQ (ORCPT ); Thu, 21 Jun 2018 12:21:16 -0400 Received: from mga05.intel.com ([192.55.52.43]:34411 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933287AbeFUQVO (ORCPT ); Thu, 21 Jun 2018 12:21:14 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2018 09:21:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,252,1526367600"; d="scan'208";a="234481400" Received: from lmrad-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.254.46]) by orsmga005.jf.intel.com with ESMTP; 21 Jun 2018 09:21:01 -0700 Date: Thu, 21 Jun 2018 19:21:01 +0300 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: Louis Collard , linux-integrity@vger.kernel.org, Peter Huewe , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, apronin@chromium.org Subject: Re: [PATCH] tpm: Add module parameter for hwrng quality. Message-ID: <20180621162101.GB11859@linux.intel.com> References: <20180608065438.110109-1-louiscollard@chromium.org> <20180618180712.GB20697@linux.intel.com> <20180618193306.GF6805@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180618193306.GF6805@ziepe.ca> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 18, 2018 at 01:33:06PM -0600, Jason Gunthorpe wrote: > > > +module_param(override_rng_quality, short, 0644); > > > > Should this be 600 i.e. not to leak this information? > > There is a real push these days against adding module parameters, and > apparently, IMA can't function with TPM as a module. > > Are you sure this shouldn't be done in some other way? Maybe a sysfs file would be a better choice for this? /Jarkko