From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 876E7C43141 for ; Thu, 21 Jun 2018 17:22:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40DE721829 for ; Thu, 21 Jun 2018 17:22:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40DE721829 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933018AbeFURWk (ORCPT ); Thu, 21 Jun 2018 13:22:40 -0400 Received: from mga14.intel.com ([192.55.52.115]:17187 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932508AbeFURWh (ORCPT ); Thu, 21 Jun 2018 13:22:37 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2018 10:22:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,252,1526367600"; d="scan'208";a="51191657" Received: from lmrad-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.254.46]) by orsmga008.jf.intel.com with ESMTP; 21 Jun 2018 10:22:27 -0700 Date: Thu, 21 Jun 2018 20:22:29 +0300 From: Jarkko Sakkinen To: Dave Hansen Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, Haim Cohen , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Borislav Petkov , Tom Lendacky , Konrad Rzeszutek Wilk , David Woodhouse , Greg Kroah-Hartman , Janakarajan Natarajan , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "open list:INTEL SGX" Subject: Re: [PATCH v11 04/13] x86, sgx: add SGX definitions to msr-index.h Message-ID: <20180621172229.GB12562@linux.intel.com> References: <20180608171216.26521-1-jarkko.sakkinen@linux.intel.com> <20180608171216.26521-5-jarkko.sakkinen@linux.intel.com> <20180619131828.GD5609@linux.intel.com> <4a92d6d2-30d9-eeaf-1afc-cfa35cae004e@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4a92d6d2-30d9-eeaf-1afc-cfa35cae004e@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 19, 2018 at 07:01:57AM -0700, Dave Hansen wrote: > On 06/19/2018 06:18 AM, Jarkko Sakkinen wrote: > > On Fri, Jun 08, 2018 at 10:25:29AM -0700, Dave Hansen wrote: > >> On 06/08/2018 10:09 AM, Jarkko Sakkinen wrote: > >>> Signed-off-by: Sean Christopherson > >>> Signed-off-by: Haim Cohen > >>> Tested-by: Serge Ayoun > >>> Reviewed-by: Jarkko Sakkinen > >>> Tested-by: Jarkko Sakkinen > >>> Signed-off-by: Jarkko Sakkinen > >> > >> These are a mess. If you're signing off on it, a review of some kind is > >> pretty implied. > >> > >> Also, how did Sean write this, send it to Haim to sign off on it, and > >> then send it to you? That seems unlikely. > > > > They've both done something to this. How should I change it then? > > Who added their Signed-off-by? > > I would probably add a single "Co-developed-by:" for each of them and a > single Signed-off-by, like commit 12c89130a56ae: > > Co-developed-by: Tony Luck > Reported-by: Mika Penttilä > Signed-off-by: Dan Williams > Cc: Al Viro > Cc: Andrew Morton > Cc: Andy Lutomirski > ... Thanks, I was not aware of that tag. /Jarkko