From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 928E7C43142 for ; Fri, 22 Jun 2018 06:04:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36AF423D9B for ; Fri, 22 Jun 2018 06:04:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="jpJmb6Yn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36AF423D9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751098AbeFVGET (ORCPT ); Fri, 22 Jun 2018 02:04:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:39858 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbeFVGER (ORCPT ); Fri, 22 Jun 2018 02:04:17 -0400 Received: from devnote (s169.156.222.122.fls.vectant.ne.jp [122.222.156.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 96A2F23D9C; Fri, 22 Jun 2018 06:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1529647457; bh=0EBEzknj7XEOX9pH1bSTlP7bpV8101Kn6Vm76Jxufpg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jpJmb6Yn/5mS/fkI+tyJzXAirhEVf8BiKgSIybgZmmoOzDyBiELO1UdCTyT3GMuyy R91XLDo6nSiqve44gUADi2cUHenGK7klF1qZ0fnejYVolYivH7kt1xcvlX/rCBHajB hImRiU4F4SteYs3F3YymT0IzzqM6NsPjEEjZFaxk= Date: Fri, 22 Jun 2018 15:04:12 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Namhyung Kim , Tom Zanussi , Arnaldo Carvalho de Melo , linux-trace-users@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org, Ravi Bangoria Subject: Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features Message-Id: <20180622150412.ef26a31acb46c5baebd97ddb@kernel.org> In-Reply-To: <20180621161648.29e7a4cc@gandalf.local.home> References: <152465856498.26224.16969986455942749517.stgit@devbox> <20180621161648.29e7a4cc@gandalf.local.home> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steve, On Thu, 21 Jun 2018 16:16:48 -0400 Steven Rostedt wrote: > Hi Masami, > > Are you going to post another version of this patch set? No, this is the latest one which I sent to LKML. Oops, it was 2 month ago now... Thank you, > > -- Steve > > > On Wed, 25 Apr 2018 21:16:06 +0900 > Masami Hiramatsu wrote: > > > Hi, > > > > This is the 7th version of the fetch-arg improvement series. > > This includes variable changes on fetcharg framework like, > > > > - Add fetcharg testcases (syntax, argN, symbol, string and array) > > and probepoint testcase. > > - Rewrite fetcharg framework with fetch_insn, switch-case based > > instead of function pointer. > > - Add "symbol" type support, which shows symbol+offset instead of > > address value. > > - Add "$argN" fetcharg, which fetches function parameters. > > (currently only for x86-64) > > - Add array type support (including string arrary :) ) , > > which enables to get fixed length array from probe-events. > > - Add array type support for perf-probe, so that user can > > dump partial array entries. > > > > V6 is here: > > https://lkml.org/lkml/2018/3/17/75 > > > > Changes from the v6 are here: > > [6/16] - Fix to return an error if failed to fetch string and > > fill zero-length data_loc in error case. > > [11/16] - Update document for restructured text. > > [15/16] - Fix README test. > > [16/16] - Add type-casting description (and note) to documentation. > > > > And rebased on the latest Steve's ftrace/core branch. > > > > Thank you, > > > > --- > > > > Masami Hiramatsu (16): > > tracing: probeevent: Cleanup print argument functions > > tracing: probeevent: Cleanup argument field definition > > tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions > > tracing: probeevent: Introduce new argument fetching code > > tracing: probeevent: Unify fetch type tables > > tracing: probeevent: Return consumed bytes of dynamic area > > tracing: probeevent: Append traceprobe_ for exported function > > tracing: probeevent: Unify fetch_insn processing common part > > tracing: probeevent: Add symbol type > > x86: ptrace: Add function argument access API > > tracing: probeevent: Add $argN for accessing function args > > tracing: probeevent: Add array type support > > selftests: ftrace: Add a testcase for symbol type > > selftests: ftrace: Add a testcase for $argN with kprobe_event > > selftests: ftrace: Add a testcase for array type with kprobe_event > > perf-probe: Add array argument support > > > > > > Documentation/trace/kprobetrace.rst | 23 + > > arch/Kconfig | 7 > > arch/x86/Kconfig | 1 > > arch/x86/include/asm/ptrace.h | 38 + > > kernel/trace/trace.c | 9 > > kernel/trace/trace_kprobe.c | 358 ++++-------- > > kernel/trace/trace_probe.c | 620 +++++++++----------- > > kernel/trace/trace_probe.h | 282 +++------ > > kernel/trace/trace_probe_tmpl.h | 216 +++++++ > > kernel/trace/trace_uprobe.c | 176 ++---- > > tools/perf/Documentation/perf-probe.txt | 12 > > tools/perf/util/probe-event.c | 20 + > > tools/perf/util/probe-event.h | 2 > > tools/perf/util/probe-file.c | 5 > > tools/perf/util/probe-file.h | 1 > > tools/perf/util/probe-finder.c | 95 ++- > > .../ftrace/test.d/kprobe/kprobe_args_argN.tc | 25 + > > .../ftrace/test.d/kprobe/kprobe_args_array.tc | 92 +++ > > .../ftrace/test.d/kprobe/kprobe_args_symbol.tc | 77 ++ > > 19 files changed, 1127 insertions(+), 932 deletions(-) > > create mode 100644 kernel/trace/trace_probe_tmpl.h > > create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_argN.tc > > create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_array.tc > > create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_symbol.tc > > > > -- > > Masami Hiramatsu (Linaro) > -- Masami Hiramatsu