From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48A85C43142 for ; Sun, 24 Jun 2018 13:49:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0199924F2F for ; Sun, 24 Jun 2018 13:49:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="hhPlB8HT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0199924F2F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752087AbeFXNtE (ORCPT ); Sun, 24 Jun 2018 09:49:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:44728 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751853AbeFXNtC (ORCPT ); Sun, 24 Jun 2018 09:49:02 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ABC5E24F1B; Sun, 24 Jun 2018 13:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1529848141; bh=PXZR2URKejDlmSINo6Y0lyqwWkjnOfnwnMRUEI5KOtA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hhPlB8HTIYuUiwOYtEZbTDOvc/LiYviYgX3jeD6C4Pa6mzS9lWW2gyeHCQlyNI04m JuAq6BbVqClGdsO2gzFWmaKmocD4x1IUlgaQfEx+ZjUtQsWU7wq5LJORzdutCncwZo d0/ZBibzGIaa4+CZ3raDyPPJ7WnSCFOlVCaPOhNc= Date: Sun, 24 Jun 2018 14:48:55 +0100 From: Jonathan Cameron To: Andreas Klinger Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, robh+dt@kernel.org, mark.rutland@arm.com, mchehab@kernel.org, davem@davemloft.net, gregkh@linuxfoundation.org, akpm@linux-foundation.org, linus.walleij@linaro.org, rdunlap@infradead.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] iio: hx711: add data-ready-delay-ns property in DT Message-ID: <20180624144855.2ed07568@archlinux> In-Reply-To: <20180624132858.GA2296@imap.1und1.de> References: <20180623185420.GA17842@arbeit> <20180624141048.7628eaac@archlinux> <20180624132858.GA2296@imap.1und1.de> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 24 Jun 2018 15:28:59 +0200 Andreas Klinger wrote: > Hi Jonathan, > > Jonathan Cameron schrieb am Sun, 24. Jun 14:10: > > On Sat, 23 Jun 2018 20:54:21 +0200 > > Andreas Klinger wrote: > > > > > add data-ready-delay-ns property for hx711 ADC > > > this is the delay after rising PD_SCK until DOUT is read and assumed to be > > > ready > > > > > > Signed-off-by: Andreas Klinger > > > > One unconnected change. I'm not sure it's wrong as such but it should not > > be in this patch. > > > > > --- > > > Documentation/devicetree/bindings/iio/adc/avia-hx711.txt | 9 ++++++++- > > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt > > > index b3629405f568..8c9bcaa4d750 100644 > > > --- a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt > > > +++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt > > > @@ -8,11 +8,18 @@ Required properties: > > > See Documentation/devicetree/bindings/gpio/gpio.txt > > > - avdd-supply: Definition of the regulator used as analog supply > > > > > > +Optional properties: > > > + - data-ready-delay-ns: additional delay in nanoseconds between rising of > > > + PD_SCK until DOUT is ready > > > + should be less then maximum PD_SCK high time which > > > + is 50000 in the datasheet > > > + > > > Example: > > > -weight@0 { > > > +weight { > > The device tree compiler (dtc) gives a warning if there is no reg = <...> > setting. That's why i changed it to be without @0. > > Should i create an individual patch for this change in this series or > create another patch which is unrelated to this series? Either is fine by me. It's such a trivial change that it really doesn't matter. Jonathan > > Andreas > > > > > Change has nothing to do with this patch... > > > > > compatible = "avia,hx711"; > > > sck-gpios = <&gpio3 10 GPIO_ACTIVE_HIGH>; > > > dout-gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>; > > > avdd-suppy = <&avdd>; > > > + data-ready-delay-ns = <1000>; > > > }; > > > > > >