From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B63C43144 for ; Mon, 25 Jun 2018 02:02:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4DAD3253B9 for ; Mon, 25 Jun 2018 02:02:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DAD3253B9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752582AbeFYCCJ (ORCPT ); Sun, 24 Jun 2018 22:02:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34588 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751834AbeFYCCI (ORCPT ); Sun, 24 Jun 2018 22:02:08 -0400 Received: from localhost (unknown [111.205.210.1]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 5D6E3CD1; Mon, 25 Jun 2018 02:02:03 +0000 (UTC) Date: Mon, 25 Jun 2018 09:57:17 +0800 From: Greg KH To: Enric Balletbo i Serra Cc: Fabio Estevam , linux-kernel , Gwendal Grignou , kernel@collabora.com, Dmitry Torokhov , linux-input@vger.kernel.org Subject: Re: [PATCH v2 5/8] Input: cros_ec_keyb - Switch to SPDX identifier. Message-ID: <20180625015717.GA30408@kroah.com> References: <20180605175429.9072-1-enric.balletbo@collabora.com> <20180605175429.9072-6-enric.balletbo@collabora.com> <7085d0bb-557c-0796-d3ae-756e000a7950@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7085d0bb-557c-0796-d3ae-756e000a7950@collabora.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 05, 2018 at 08:14:24PM +0200, Enric Balletbo i Serra wrote: > Hi Fabio, > > On 05/06/18 20:04, Fabio Estevam wrote: > > Hi Enric, > > > > On Tue, Jun 5, 2018 at 2:54 PM, Enric Balletbo i Serra > > wrote: > >> Adopt the SPDX license identifier headers to ease license compliance > >> management. > >> > >> Signed-off-by: Enric Balletbo i Serra > >> --- > >> > >> Changes in v2: > >> - [6/9] Do not remove last paragraph. > >> > >> drivers/input/keyboard/cros_ec_keyb.c | 34 ++++++++++----------------- > >> 1 file changed, 12 insertions(+), 22 deletions(-) > >> > >> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c > >> index 79eb29550c34..91b2839c12df 100644 > >> --- a/drivers/input/keyboard/cros_ec_keyb.c > >> +++ b/drivers/input/keyboard/cros_ec_keyb.c > >> @@ -1,25 +1,15 @@ > >> -/* > >> - * ChromeOS EC keyboard driver > >> - * > >> - * Copyright (C) 2012 Google, Inc > >> - * > >> - * This software is licensed under the terms of the GNU General Public > >> - * License version 2, as published by the Free Software Foundation, and > > > > Original text says GPL-2.0... > > > >> - * may be copied, distributed, and modified under those terms. > >> - * > >> - * This program is distributed in the hope that it will be useful, > >> - * but WITHOUT ANY WARRANTY; without even the implied warranty of > >> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > >> - * GNU General Public License for more details. > >> - * > >> - * This driver uses the Chrome OS EC byte-level message-based protocol for > >> - * communicating the keyboard state (which keys are pressed) from a keyboard EC > >> - * to the AP over some bus (such as i2c, lpc, spi). The EC does debouncing, > >> - * but everything else (including deghosting) is done here. The main > >> - * motivation for this is to keep the EC firmware as simple as possible, since > >> - * it cannot be easily upgraded and EC flash/IRAM space is relatively > >> - * expensive. > >> - */ > >> +// SPDX-License-Identifier: GPL-2.0+ > > > > but here you add a GPL-2.0+ type. > > > > Right, but the module license is set to GPL which means GNU Public License v2 or > later, see [1]. So, there is a mismatch. In such cases I assumed GPL-2.0+ as the > default. These mismatches are common so I think that should be fine for the > authors, if someone is disagree just let me know and I will change. NO! The license text is what you need to follow as almost everyone gets the MODULE_LICENSE() stuff wrong. You can not follow the MODULE_LICENSE marking for determining GPLv2 vs. GPLv2+ at this point in time. After we get the SPDX stuff all cleaned up then we can go and fix up the MODULE_LICENSE mismatch. So again, always defer to the license text in the file, NOT the MODULE_LICENSE() marking. thanks, greg k-h