public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/gma500: Fix compile warning
@ 2018-06-25 12:33 Gustavo A. R. Silva
  2018-06-26 13:28 ` Ville Syrjälä
  0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-06-25 12:33 UTC (permalink / raw)
  To: Patrik Jakobsson, David Airlie, Daniel Stone
  Cc: dri-devel, linux-kernel, Gustavo A. R. Silva

Fix the following compile warning:

warning: unused variable ‘psbfb’ [-Wunused-variable]
  struct psb_framebuffer *psbfb = to_psb_fb(fb);

Fixes: c7cbed560ce2 ("drm/gma500: Fix Medfield for drm_framebuffer move")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/gpu/drm/gma500/mdfld_intel_display.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c b/drivers/gpu/drm/gma500/mdfld_intel_display.c
index 881d613..2b9fa01 100644
--- a/drivers/gpu/drm/gma500/mdfld_intel_display.c
+++ b/drivers/gpu/drm/gma500/mdfld_intel_display.c
@@ -167,7 +167,6 @@ static int mdfld__intel_pipe_set_base(struct drm_crtc *crtc, int x, int y,
 	struct drm_psb_private *dev_priv = dev->dev_private;
 	struct drm_framebuffer *fb = crtc->primary->fb;
 	struct gma_crtc *gma_crtc = to_gma_crtc(crtc);
-	struct psb_framebuffer *psbfb = to_psb_fb(fb);
 	int pipe = gma_crtc->pipe;
 	const struct psb_offset *map = &dev_priv->regmap[pipe];
 	unsigned long start, offset;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/gma500: Fix compile warning
  2018-06-25 12:33 [PATCH] drm/gma500: Fix compile warning Gustavo A. R. Silva
@ 2018-06-26 13:28 ` Ville Syrjälä
  2018-06-26 13:37   ` Gustavo A. R. Silva
  0 siblings, 1 reply; 3+ messages in thread
From: Ville Syrjälä @ 2018-06-26 13:28 UTC (permalink / raw)
  To: Gustavo A. R. Silva
  Cc: Patrik Jakobsson, David Airlie, Daniel Stone, linux-kernel,
	dri-devel

On Mon, Jun 25, 2018 at 07:33:55AM -0500, Gustavo A. R. Silva wrote:
> Fix the following compile warning:
> 
> warning: unused variable ‘psbfb’ [-Wunused-variable]
>   struct psb_framebuffer *psbfb = to_psb_fb(fb);
> 
> Fixes: c7cbed560ce2 ("drm/gma500: Fix Medfield for drm_framebuffer move")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

I sent the same patch a few days ago. Instead of hunting for an r-b
I just went ahead and pushed your version. Thanks for the patch.

> ---
>  drivers/gpu/drm/gma500/mdfld_intel_display.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c b/drivers/gpu/drm/gma500/mdfld_intel_display.c
> index 881d613..2b9fa01 100644
> --- a/drivers/gpu/drm/gma500/mdfld_intel_display.c
> +++ b/drivers/gpu/drm/gma500/mdfld_intel_display.c
> @@ -167,7 +167,6 @@ static int mdfld__intel_pipe_set_base(struct drm_crtc *crtc, int x, int y,
>  	struct drm_psb_private *dev_priv = dev->dev_private;
>  	struct drm_framebuffer *fb = crtc->primary->fb;
>  	struct gma_crtc *gma_crtc = to_gma_crtc(crtc);
> -	struct psb_framebuffer *psbfb = to_psb_fb(fb);
>  	int pipe = gma_crtc->pipe;
>  	const struct psb_offset *map = &dev_priv->regmap[pipe];
>  	unsigned long start, offset;
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/gma500: Fix compile warning
  2018-06-26 13:28 ` Ville Syrjälä
@ 2018-06-26 13:37   ` Gustavo A. R. Silva
  0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-06-26 13:37 UTC (permalink / raw)
  To: Ville Syrjälä
  Cc: Patrik Jakobsson, David Airlie, Daniel Stone, linux-kernel,
	dri-devel



On 06/26/2018 08:28 AM, Ville Syrjälä wrote:
> On Mon, Jun 25, 2018 at 07:33:55AM -0500, Gustavo A. R. Silva wrote:
>> Fix the following compile warning:
>>
>> warning: unused variable ‘psbfb’ [-Wunused-variable]
>>   struct psb_framebuffer *psbfb = to_psb_fb(fb);
>>
>> Fixes: c7cbed560ce2 ("drm/gma500: Fix Medfield for drm_framebuffer move")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> 
> I sent the same patch a few days ago. Instead of hunting for an r-b
> I just went ahead and pushed your version. Thanks for the patch.
> 

Glad to help :)

Thanks
--
Gustavo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-26 13:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-25 12:33 [PATCH] drm/gma500: Fix compile warning Gustavo A. R. Silva
2018-06-26 13:28 ` Ville Syrjälä
2018-06-26 13:37   ` Gustavo A. R. Silva

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox