From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA4AC43144 for ; Mon, 25 Jun 2018 21:01:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B8C026117 for ; Mon, 25 Jun 2018 21:01:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B8C026117 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752380AbeFYVB3 (ORCPT ); Mon, 25 Jun 2018 17:01:29 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:52152 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751556AbeFYVB0 (ORCPT ); Mon, 25 Jun 2018 17:01:26 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ACF7E81A4E9F; Mon, 25 Jun 2018 21:01:25 +0000 (UTC) Received: from krava (ovpn-204-34.brq.redhat.com [10.40.204.34]) by smtp.corp.redhat.com (Postfix) with SMTP id 6D6132026D5B; Mon, 25 Jun 2018 21:01:22 +0000 (UTC) Date: Mon, 25 Jun 2018 23:01:21 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Andi Kleen , Thomas Richter , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, Jiri Olsa , Namhyung Kim Subject: Re: [PATCH 4/4 v3] perf stat: Add transaction flag (-T) support for s390 Message-ID: <20180625210121.GA13952@krava> References: <20180625125856.20262-1-tmricht@linux.ibm.com> <20180625145247.GY20477@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180625145247.GY20477@kernel.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Mon, 25 Jun 2018 21:01:25 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Mon, 25 Jun 2018 21:01:25 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jolsa@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 25, 2018 at 11:52:47AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Jun 25, 2018 at 02:58:56PM +0200, Thomas Richter escreveu: > > perf stat command line flag -T to display transaction counters is > > currently supported for x86 only. > > Add support for s390. It is based on the metrics flag -M transaction > > using the architecture dependend json files. This requires a metric > > named "transaction" in the json files for the platform. > > You forgot to CC Andi in this post, Andi, is everything ok now? May I > have your reviewed-by or acked-by? hu, I haven't got this one either.. will check jirka > > Thanks, > > - Arnaldo > > > v2 --> v3: > > Introduce new function metricgroup__has_metric() to check for > > the existance of a metric named transaction. > > > > As suggested by Andi Kleen, this is the new approach to support > > transactions counters. Other architectures will follow. > > > > Output before: > > [root@p23lp27 perf]# ./perf stat -T -- sleep 1 > > Cannot set up transaction events > > [root@p23lp27 perf]# > > > > Output after: > > [root@s35lp76 perf]# ./perf stat -T -- ~/mytesttx 1 >/tmp/111 > > > > Performance counter stats for '/root/mytesttx 1': > > > > 1 tx_c_tend # 13.0 transaction > > 1 tx_nc_tend > > 11 tx_nc_tabort > > 0 tx_c_tabort_special > > 0 tx_c_tabort_no_special > > > > 0.001070109 seconds time elapsed > > > > [root@s35lp76 perf]# > > > > Suggested-by: Andi Kleen > > Signed-off-by: Thomas Richter > > Suggested-by: Hendrik Brueckner > > Reviewed-by: Hendrik Brueckner > > --- > > tools/perf/builtin-stat.c | 12 ++++++++++++ > > tools/perf/util/metricgroup.c | 23 +++++++++++++++++++++++ > > tools/perf/util/metricgroup.h | 1 + > > 3 files changed, 36 insertions(+) > > > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > > index a4f662a462c6..e309279e7b04 100644 > > --- a/tools/perf/builtin-stat.c > > +++ b/tools/perf/builtin-stat.c > > @@ -2425,6 +2425,18 @@ static int add_default_attributes(void) > > if (transaction_run) { > > struct parse_events_error errinfo; > > > > + /* Handle -T as -M transaction. Once platform specific metrics > > + * support has been added to the json files, all archictures > > + * will use this approach. To determine transaction support > > + * on an architecture test for such a metric name. > > + */ > > + if (metricgroup__has_metric("transaction")) { > > + struct option opt = { .value = &evsel_list }; > > + > > + return metricgroup__parse_groups(&opt, "transaction", > > + &metric_events); > > + } > > + > > if (pmu_have_event("cpu", "cycles-ct") && > > pmu_have_event("cpu", "el-start")) > > err = parse_events(evsel_list, transaction_attrs, > > diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c > > index 1ddc3d1d0147..90cff5226ecc 100644 > > --- a/tools/perf/util/metricgroup.c > > +++ b/tools/perf/util/metricgroup.c > > @@ -490,3 +490,26 @@ int metricgroup__parse_groups(const struct option *opt, > > metricgroup__free_egroups(&group_list); > > return ret; > > } > > + > > +bool metricgroup__has_metric(const char *metric) > > +{ > > + struct pmu_events_map *map = perf_pmu__find_map(NULL); > > + struct pmu_event *pe; > > + int i; > > + > > + if (!map) > > + return false; > > + > > + for (i = 0; ; i++) { > > + pe = &map->table[i]; > > + > > + if (!pe->name && !pe->metric_group && !pe->metric_name) > > + break; > > + if (!pe->metric_expr) > > + continue; > > + if (match_metric(pe->metric_group, metric) || > > + match_metric(pe->metric_name, metric)) > > + return true; > > + } > > + return false; > > +} > > diff --git a/tools/perf/util/metricgroup.h b/tools/perf/util/metricgroup.h > > index 06854e125ee7..8a155dba0581 100644 > > --- a/tools/perf/util/metricgroup.h > > +++ b/tools/perf/util/metricgroup.h > > @@ -28,4 +28,5 @@ int metricgroup__parse_groups(const struct option *opt, > > struct rblist *metric_events); > > > > void metricgroup__print(bool metrics, bool groups, char *filter, bool raw); > > +bool metricgroup__has_metric(const char *metric); > > #endif > > -- > > 2.14.3