From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: John Whitmore <arigead@gmail.com>
Cc: Justin Skists <justin.skists@juzza.co.uk>,
devel@driverdev.osuosl.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
John Whitmore <johnfwhitmore@gmail.com>
Subject: Re: [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.
Date: Tue, 26 Jun 2018 11:56:40 +0800 [thread overview]
Message-ID: <20180626035640.GA29538@kroah.com> (raw)
In-Reply-To: <20180625195025.xfbrlj7citq3qx6s@xux707-tw>
On Mon, Jun 25, 2018 at 08:50:26PM +0100, John Whitmore wrote:
> On Mon, Jun 25, 2018 at 02:05:04PM +0100, Justin Skists wrote:
> >
> > > On 25 June 2018 at 13:36 John Whitmore <arigead@gmail.com> wrote:
> > >
> > >
> > > On Mon, Jun 25, 2018 at 12:06:30PM +0300, Andy Shevchenko wrote:
> > > > On Sun, Jun 24, 2018 at 6:34 PM, John Whitmore <johnfwhitmore@gmail.com> wrote:
> > > > > Replaced memory initialising loop with memset, as suggested by Andy Shevchenko
> > > > >
> > > >
> > > > Suggested-by ?
> > > >
> > >
> > > Em, not sure how to respond, it certainly wasn't my idea. I was just making
> > > coding style changes, badly. ;)
> >
> > Suggested-by is a tag for patches, to give credit. For example:
> >
> > https://elixir.bootlin.com/linux/v4.18-rc1/source/Documentation/process/submitting-patches.rst
> >
> > See section "13) Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes:"
> >
> > Hope that helps,
> > Justin.
>
> Oops... that helps thank you. I have to re-read that document, it obvioiusly
> didn't all sink in :(
I've dropped this patch, can you fix it up and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2018-06-26 3:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-24 15:34 staging: rtl8192u: v3 Coding style changes. Plus one change to use memset() John Whitmore
2018-06-24 15:34 ` [PATCH v3 1/8] staging: rtl8192u: change block comments to prefered style - Coding Style John Whitmore
2018-06-24 15:34 ` [PATCH v3 2/8] staging: rtl8192u: Correct indentation of switch statement " John Whitmore
2018-06-24 15:34 ` [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop John Whitmore
2018-06-25 9:06 ` Andy Shevchenko
2018-06-25 12:36 ` John Whitmore
2018-06-25 13:05 ` Justin Skists
2018-06-25 19:50 ` John Whitmore
2018-06-26 3:56 ` Greg Kroah-Hartman [this message]
2018-06-27 15:48 ` John Whitmore
2018-06-24 15:34 ` [PATCH v3 4/8] staging: rtl8192u: Truncate block comments to 80 character length - Style John Whitmore
2018-06-24 15:34 ` [PATCH v3 5/8] staging: rtl8192u: Use %s and __func__ instead of hardcoded string " John Whitmore
2018-06-26 3:56 ` Greg KH
2018-06-27 20:22 ` John Whitmore
2018-06-28 7:38 ` Dan Carpenter
2018-06-28 12:32 ` John Whitmore
2018-06-28 12:48 ` Greg KH
2018-06-24 15:34 ` [PATCH v3 6/8] staging: rtl8192u: Remove braces from single statement blocks " John Whitmore
2018-06-24 15:34 ` [PATCH v3 7/8] staging: rtl8192u: Correct if statement - Coding Style John Whitmore
2018-06-24 15:59 ` Joe Perches
2018-06-25 11:46 ` John Whitmore
2018-06-24 15:34 ` [PATCH v3 8/8] staging: rtl8192u: Correction of spelling mistake in comment John Whitmore
-- strict thread matches above, loose matches on Subject: below --
2018-06-24 15:40 staging: rtl8192u: V3 Coding style changes. Plus one change to use memset() John Whitmore
2018-06-24 15:40 ` [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop John Whitmore
2018-06-24 15:49 ` John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180626035640.GA29538@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=arigead@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=johnfwhitmore@gmail.com \
--cc=justin.skists@juzza.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox