From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F685C43142 for ; Tue, 26 Jun 2018 18:09:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6287F26EBF for ; Tue, 26 Jun 2018 18:09:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6287F26EBF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752741AbeFZSJo convert rfc822-to-8bit (ORCPT ); Tue, 26 Jun 2018 14:09:44 -0400 Received: from mail.bootlin.com ([62.4.15.54]:45818 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751943AbeFZSJm (ORCPT ); Tue, 26 Jun 2018 14:09:42 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id C742B207F3; Tue, 26 Jun 2018 20:09:39 +0200 (CEST) Received: from xps13 (unknown [91.224.148.103]) by mail.bootlin.com (Postfix) with ESMTPSA id 1FF43203B0; Tue, 26 Jun 2018 20:09:29 +0200 (CEST) Date: Tue, 26 Jun 2018 20:09:28 +0200 From: Miquel Raynal To: Masahiro Yamada Cc: Boris Brezillon , Dinh Nguyen , Richard Weinberger , DTML , Linux Kernel Mailing List , linux-mtd , Rob Herring , Mark Rutland , Marek =?UTF-8?B?VmHFoXV0?= , Brian Norris , David Woodhouse Subject: Re: [PATCH] arm: dts: socfpga: denali needs nand_x_clk too Message-ID: <20180626200928.29aca979@xps13> In-Reply-To: References: <20180619120719.26921-1-richard@nod.at> <3320422.EJ8D6C0VHL@blindfold> <20180625165506.484e025f@bbrezillon> Organization: Bootlin X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro, On Tue, 26 Jun 2018 11:38:21 +0900, Masahiro Yamada wrote: > 2018-06-25 23:55 GMT+09:00 Boris Brezillon : > > On Mon, 25 Jun 2018 09:50:18 -0500 > > Dinh Nguyen wrote: > > > >> On 06/22/2018 10:58 AM, Richard Weinberger wrote: > >> > Masahiro, > >> > > >> > Am Freitag, 22. Juni 2018, 16:37:21 CEST schrieb Masahiro Yamada: > >> >> Hi Richard, > >> >> > >> >> > >> >> 2018-06-19 21:07 GMT+09:00 Richard Weinberger : > >> >>> The denali NAND flash controller needs at least two clocks to operate, > >> >>> nand_clk and nand_x_clk. > >> >>> Since 1bb88666775e ("mtd: nand: denali: handle timing parameters by > >> >>> setup_data_interface()") nand_x_clk is used to derive timing settings. > >> >>> > >> >>> Signed-off-by: Richard Weinberger > >> >>> --- > >> >>> Strictly speaking denali needs a ecc_clk too, but AFAIK such a clock > >> >>> is not present on this SoC. > >> >>> But my SoCFPGA knowledge is very limited. > >> >>> > >> >>> Thanks, > >> >>> //richard > >> >>> --- > >> >>> arch/arm/boot/dts/socfpga.dtsi | 3 ++- > >> >>> 1 file changed, 2 insertions(+), 1 deletion(-) > >> >>> > >> >>> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi > >> >>> index 486d4e7433ed..562f7b375bbd 100644 > >> >>> --- a/arch/arm/boot/dts/socfpga.dtsi > >> >>> +++ b/arch/arm/boot/dts/socfpga.dtsi > >> >>> @@ -754,7 +754,8 @@ > >> >>> reg-names = "nand_data", "denali_reg"; > >> >>> interrupts = <0x0 0x90 0x4>; > >> >>> dma-mask = <0xffffffff>; > >> >>> - clocks = <&nand_clk>; > >> >>> + clocks = <&nand_clk>, <&nand_x_clk>; > >> >>> + clock-names = "nand", "nand_x"; > >> >> > >> >> > >> >> IMHO, this should be > >> >> > >> >> clocks = <&nand_clk>, <&nand_x_clk>, <&nand_x_clk>; > >> >> clock-names = "nand", "nand_x", "ecc"; > >> > >> No, it should be just the nand_x and ecc. > >> > >> There's already a patch to use the nand_x_clk and not the nand_clk. > > > Different people try to fix the problem in different ways. > > I think it is due to miscommunication across sub-systems. Is the series named mtd: rawnand: denali: add new clocks and improve setup_data_interface still valid? I am about to apply it (patches 2/5 to 5/5) but it looks like the discussion is still ongoing. Thanks, Miquèl