From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E63E3C43144 for ; Wed, 27 Jun 2018 08:56:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9247D264CD for ; Wed, 27 Jun 2018 08:56:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9247D264CD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaiser.cx Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933849AbeF0I4s (ORCPT ); Wed, 27 Jun 2018 04:56:48 -0400 Received: from botnar.kaiser.cx ([176.28.20.183]:45260 "EHLO botnar.kaiser.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932549AbeF0I4r (ORCPT ); Wed, 27 Jun 2018 04:56:47 -0400 Received: from martin by botnar.kaiser.cx with local (Exim 4.72) (envelope-from ) id 1fY6EJ-0008To-Sl; Wed, 27 Jun 2018 10:55:11 +0200 Date: Wed, 27 Jun 2018 10:55:11 +0200 From: Martin Kaiser To: Miquel Raynal Cc: Boris Brezillon , David Woodhouse , Sascha Hauer , Fabio Estevam , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: rawnand: mxc: remove __init qualifier from mxcnd_probe_dt Message-ID: <20180627085511.GA31924@botnar.kaiser.cx> References: <1529679025-5735-1-git-send-email-martin@kaiser.cx> <20180626091005.08d56b2a@xps13> <20180626092413.703249c8@bbrezillon> <20180626093650.5835593b@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180626093650.5835593b@xps13> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Miquel & Boris, thanks for your feedback. Thus wrote Miquel Raynal (miquel.raynal@bootlin.com): > Hi Boris, > On Tue, 26 Jun 2018 09:24:13 +0200, Boris Brezillon > wrote: > > On Tue, 26 Jun 2018 09:10:05 +0200 > > Miquel Raynal wrote: > > > Hi Martin, Boris, > > > On Fri, 22 Jun 2018 16:50:25 +0200, Martin Kaiser > > > wrote: > > > > mxcnd_probe_dt is called from mxcnd_probe, which is not marked as __init. > > > I think this line is just a side note and should be at the end of the > > > commit log. > > > > Using the sysfs unbind, bind nodes, mxcnd_probe and mxcnd_probe_dt can > > > > potentially be called at any time. After the __init functions are cleaned, > > > > mxcnd_probe_dt is no longer available. Calling it anyway causes a crash. > > > The above paragraph explains the problem and the solution, you can just > > > add something like "mcvnd_probe is untouched because it is already not > > > marked as __init" instead of the first line. > > > > Signed-off-by: Martin Kaiser > > > Boris, do you think this patch is a good candidate for stable? > > > If yes, Martin, could you please add a couple of stable/fixes tags above > > > your SoB? > > We should at least have a Fixes tag. For the stable one, I'm not so > > sure because the bug does not exist in practice (the compiler always > > inline mxcnd_probe_dt()). > Fine, then a Fixes tag will be enough and I will take it into > nand/next as it is not urgent at all to have it in the main tree. I agree that this is not a candidate for stable. I just sent an update with a Fixes tag and rephrased commit message. Best regards, Martin