public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx6: RIoTboard Add chosen stdout-path property
@ 2018-06-18 15:42 Emmanuel Vadot
  2018-06-18 15:47 ` Fabio Estevam
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Emmanuel Vadot @ 2018-06-18 15:42 UTC (permalink / raw)
  To: shawnguo, s.hauer, kernel, fabio.estevam, linux-imx, robh+dt,
	mark.rutland
  Cc: linux-arm-kernel, devicetree, linux-kernel, Emmanuel Vadot

The RIoTboard debug uart is connected to serial1.
Add a chosen property in the DTS so OS knows what serial port to use for
the console.

Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
 arch/arm/boot/dts/imx6dl-riotboard.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
index 2e98c92adff7..315d2ae6fa45 100644
--- a/arch/arm/boot/dts/imx6dl-riotboard.dts
+++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
@@ -19,6 +19,10 @@
 		reg = <0x10000000 0x40000000>;
 	};
 
+	chosen {
+		stdout-path = "serial1:115200n8";
+	};
+
 	regulators {
 		compatible = "simple-bus";
 		#address-cells = <1>;
-- 
2.17.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: imx6: RIoTboard Add chosen stdout-path property
  2018-06-18 15:42 [PATCH] ARM: dts: imx6: RIoTboard Add chosen stdout-path property Emmanuel Vadot
@ 2018-06-18 15:47 ` Fabio Estevam
  2018-06-18 16:03 ` Lucas Stach
  2018-06-28  2:20 ` Shawn Guo
  2 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2018-06-18 15:47 UTC (permalink / raw)
  To: Emmanuel Vadot
  Cc: Shawn Guo, Sascha Hauer, Sascha Hauer, Fabio Estevam,
	NXP Linux Team, Rob Herring, Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

On Mon, Jun 18, 2018 at 12:42 PM, Emmanuel Vadot <manu@freebsd.org> wrote:
> The RIoTboard debug uart is connected to serial1.
> Add a chosen property in the DTS so OS knows what serial port to use for
> the console.
>
> Signed-off-by: Emmanuel Vadot <manu@freebsd.org>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: imx6: RIoTboard Add chosen stdout-path property
  2018-06-18 15:42 [PATCH] ARM: dts: imx6: RIoTboard Add chosen stdout-path property Emmanuel Vadot
  2018-06-18 15:47 ` Fabio Estevam
@ 2018-06-18 16:03 ` Lucas Stach
  2018-06-18 16:30   ` Emmanuel Vadot
  2018-06-28  2:20 ` Shawn Guo
  2 siblings, 1 reply; 5+ messages in thread
From: Lucas Stach @ 2018-06-18 16:03 UTC (permalink / raw)
  To: Emmanuel Vadot, shawnguo, s.hauer, kernel, fabio.estevam,
	linux-imx, robh+dt, mark.rutland
  Cc: devicetree, linux-kernel, linux-arm-kernel

Am Montag, den 18.06.2018, 17:42 +0200 schrieb Emmanuel Vadot:
> The RIoTboard debug uart is connected to serial1.
> Add a chosen property in the DTS so OS knows what serial port to use for
> the console.
> 
> > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> ---
>  arch/arm/boot/dts/imx6dl-riotboard.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
> index 2e98c92adff7..315d2ae6fa45 100644
> --- a/arch/arm/boot/dts/imx6dl-riotboard.dts
> +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
> @@ -19,6 +19,10 @@
> >  		reg = <0x10000000 0x40000000>;
> >  	};
>  
> > +	chosen {
> +		stdout-path = "serial1:115200n8";

If there a reason to deviate from the "stdout-path = &uart1;" notation
used by other i.MX boards?

Regards,
Lucas

> +	};
> +
> >  	regulators {
> >  		compatible = "simple-bus";
> >  		#address-cells = <1>;

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: imx6: RIoTboard Add chosen stdout-path property
  2018-06-18 16:03 ` Lucas Stach
@ 2018-06-18 16:30   ` Emmanuel Vadot
  0 siblings, 0 replies; 5+ messages in thread
From: Emmanuel Vadot @ 2018-06-18 16:30 UTC (permalink / raw)
  To: Lucas Stach
  Cc: Emmanuel Vadot, shawnguo, s.hauer, kernel, fabio.estevam,
	linux-imx, robh+dt, mark.rutland, devicetree, linux-kernel,
	linux-arm-kernel

On Mon, 18 Jun 2018 18:03:17 +0200
Lucas Stach <l.stach@pengutronix.de> wrote:

> Am Montag, den 18.06.2018, 17:42 +0200 schrieb Emmanuel Vadot:
> > The RIoTboard debug uart is connected to serial1.
> > Add a chosen property in the DTS so OS knows what serial port to use for
> > the console.
> > 
> > > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> > ---
> >  arch/arm/boot/dts/imx6dl-riotboard.dts | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
> > index 2e98c92adff7..315d2ae6fa45 100644
> > --- a/arch/arm/boot/dts/imx6dl-riotboard.dts
> > +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
> > @@ -19,6 +19,10 @@
> > >  		reg = <0x10000000 0x40000000>;
> > >  	};
> >  
> > > +	chosen {
> > +		stdout-path = "serial1:115200n8";
> 
> If there a reason to deviate from the "stdout-path = &uart1;" notation
> used by other i.MX boards?
> 
> Regards,
> Lucas

 This is, AFAIK, the proper way to specify the stdout-path.
 See
https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/chosen.txt#L31

 Cheers,

> > +	};
> > +
> > >  	regulators {
> > >  		compatible = "simple-bus";
> > >  		#address-cells = <1>;
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: imx6: RIoTboard Add chosen stdout-path property
  2018-06-18 15:42 [PATCH] ARM: dts: imx6: RIoTboard Add chosen stdout-path property Emmanuel Vadot
  2018-06-18 15:47 ` Fabio Estevam
  2018-06-18 16:03 ` Lucas Stach
@ 2018-06-28  2:20 ` Shawn Guo
  2 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2018-06-28  2:20 UTC (permalink / raw)
  To: Emmanuel Vadot
  Cc: s.hauer, kernel, fabio.estevam, linux-imx, robh+dt, mark.rutland,
	devicetree, linux-kernel, linux-arm-kernel

On Mon, Jun 18, 2018 at 05:42:57PM +0200, Emmanuel Vadot wrote:
> The RIoTboard debug uart is connected to serial1.
> Add a chosen property in the DTS so OS knows what serial port to use for
> the console.
> 
> Signed-off-by: Emmanuel Vadot <manu@freebsd.org>

Applied, thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-06-28  2:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-18 15:42 [PATCH] ARM: dts: imx6: RIoTboard Add chosen stdout-path property Emmanuel Vadot
2018-06-18 15:47 ` Fabio Estevam
2018-06-18 16:03 ` Lucas Stach
2018-06-18 16:30   ` Emmanuel Vadot
2018-06-28  2:20 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox